Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756339AbZLWT4m (ORCPT ); Wed, 23 Dec 2009 14:56:42 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757058AbZLWT4b (ORCPT ); Wed, 23 Dec 2009 14:56:31 -0500 Received: from kroah.org ([198.145.64.141]:52959 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756803AbZLWTxP (ORCPT ); Wed, 23 Dec 2009 14:53:15 -0500 From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Phil Carmody , Greg Kroah-Hartman Subject: [PATCH 08/10] driver core: Prevent reference to freed memory on error path Date: Wed, 23 Dec 2009 11:52:41 -0800 Message-Id: <1261597963-18323-8-git-send-email-gregkh@suse.de> X-Mailer: git-send-email 1.6.5.6 In-Reply-To: <20091223194955.GB18101@kroah.com> References: <20091223194955.GB18101@kroah.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 981 Lines: 35 From: Phil Carmody priv is drv->p. So only free drv->p after we've finished using priv. Found using a static code analysis tool Signed-off-by: Phil Carmody Signed-off-by: Greg Kroah-Hartman --- drivers/base/bus.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/base/bus.c b/drivers/base/bus.c index 63c143e..c0c5a43 100644 --- a/drivers/base/bus.c +++ b/drivers/base/bus.c @@ -703,9 +703,9 @@ int bus_add_driver(struct device_driver *drv) return 0; out_unregister: + kobject_put(&priv->kobj); kfree(drv->p); drv->p = NULL; - kobject_put(&priv->kobj); out_put_bus: bus_put(bus); return error; -- 1.6.5.7 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/