Message-ID: <4B32A1EB.2020805@windriver.com>
Date: Wed, 23 Dec 2009 17:04:11 -0600
From: Jason Wessel <jason.wessel@windriver.com>
User-Agent: Thunderbird 2.0.0.23 (X11/20090817)
MIME-Version: 1.0
To: David Miller <davem@davemloft.net>
CC: linux-kernel@vger.kernel.org, kgdb-bugreport@lists.sourceforge.net,
       kdb@oss.sgi.com, mingo@elte.hu
Subject: Re: [PATCH 07/37] kgdb,sparc: Add in kgdb_arch_set_pc for sparc
References: <1261603190-5036-6-git-send-email-jason.wessel@windriver.com><1261603190-5036-7-git-send-email-jason.wessel@windriver.com><1261603190-5036-8-git-send-email-jason.wessel@windriver.com> <20091223.134837.189694575.davem@davemloft.net>
In-Reply-To: <20091223.134837.189694575.davem@davemloft.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1440
Lines: 45


David Miller wrote:
> From: Jason Wessel <jason.wessel@windriver.com>
> Date: Wed, 23 Dec 2009 15:19:20 -0600
>
>   
>> +void kgdb_arch_set_pc(struct pt_regs *regs, unsigned long ip)
>> +{
>> +       regs->pc = regs->npc;
>> +       regs->npc = ip;
>> +}
>> +
>>     
>
> Is this right?
>
> It should probably be something like:
>
>   
Just because it didn't crash doesn't mean it is right :-)

I'll go with your implementation which according to the instruction
manual is the right way.  This particular function doesn't really get
exercised with out the arch specific hardware or software single
stepping code, which is not a part of this series at the moment.

This fix and the other fix you asked about are both in kgdb-next which
feeds into linux-next, if you are ultimately ok with the changes, I'll
add an ack from you as well.

Hopefully there is enough time to get the kdb shape for the next kernel
merge window.

http://git.kernel.org/?p=linux/kernel/git/jwessel/linux-2.6-kgdb.git;a=commitdiff;h=ed088ec6e6e7e245c060d068d333648eff06dd4b
and
http://git.kernel.org/?p=linux/kernel/git/jwessel/linux-2.6-kgdb.git;a=commitdiff;h=c5dc61eb8d1c347ff3eadc1bccae07437d85779a

Thanks,
Jason.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/