Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755205AbZLXFys (ORCPT ); Thu, 24 Dec 2009 00:54:48 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754357AbZLXFyr (ORCPT ); Thu, 24 Dec 2009 00:54:47 -0500 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:55069 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754183AbZLXFyq (ORCPT ); Thu, 24 Dec 2009 00:54:46 -0500 Date: Wed, 23 Dec 2009 21:54:48 -0800 (PST) Message-Id: <20091223.215448.241930752.davem@davemloft.net> To: jarkao2@gmail.com Cc: rl@hellgate.ch, wrar@altlinux.org, lists@nerdbynature.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] net/via-rhine: Fix scheduling while atomic bugs From: David Miller In-Reply-To: <20091222173641.GA3093@del.dom.local> References: <20091222150045.GA5355@wrars-comp.wrarsdomain> <20091222152658.GA16043@core.hellgate.ch> <20091222173641.GA3093@del.dom.local> X-Mailer: Mew version 6.3 on Emacs 23.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 938 Lines: 22 From: Jarek Poplawski Date: Tue, 22 Dec 2009 18:36:42 +0100 > There are BUGs "scheduling while atomic" triggered by the timer > rhine_tx_timeout(). They are caused by calling napi_disable() (with > msleep()). This patch fixes it by moving most of the timer content to > the workqueue function (similarly to other drivers, like tg3), with > spin_lock() changed to BH version. > > Additionally, there is spin_lock_irq() moved in rhine_close() to > exclude napi_disable() etc., also tg3's way. > > Reported-by: Andrey Rahmatullin > Tested-by: Andrey Rahmatullin > Signed-off-by: Jarek Poplawski Applied, thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/