Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756375AbZLXGyI (ORCPT ); Thu, 24 Dec 2009 01:54:08 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756251AbZLXGyG (ORCPT ); Thu, 24 Dec 2009 01:54:06 -0500 Received: from mail-ew0-f219.google.com ([209.85.219.219]:41904 "EHLO mail-ew0-f219.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755574AbZLXGyC (ORCPT ); Thu, 24 Dec 2009 01:54:02 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; b=XvzoKIGZ4cBxWSM0/OeTc8Uudtvit3SiG/JwXUfbHpENf6eRuhAPs2W2/0HjtQE+DT EkUus7RQxGAKXYzzV+9kC0NCMhGbKVapgL9g18lp2DFQTgZjt5rVdKqFCV2VQtarlpYd wkkgDfMWmRsnlx1fhJ3COMCi0bYgMo3B60vKI= Date: Thu, 24 Dec 2009 07:53:57 +0100 From: Borislav Petkov To: Joe Perches Cc: Andrew Morton , lkml Subject: Re: [PATCH] scripts/get_maintainer.pl: add support to read patch from STDIN Message-ID: <20091224065357.GB26621@liondog.tnic> Mail-Followup-To: Borislav Petkov , Joe Perches , Andrew Morton , lkml References: <9ea470500912230555k6b72407al730da6361d8aba0f@mail.gmail.com> <1261610824.1923.58.camel@Joe-Laptop.home> <20091224064556.GA26621@liondog.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20091224064556.GA26621@liondog.tnic> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1113 Lines: 35 On Thu, Dec 24, 2009 at 07:45:56AM +0100, Borislav Petkov wrote: > On Wed, Dec 23, 2009 at 03:27:04PM -0800, Joe Perches wrote: > > On Wed, 2009-12-23 at 14:55 +0100, Borislav Petkov wrote: > > > Teach get_maintainer.pl to read a diff from STDIN > > > > How about this instead? > > > > Doesn't need or accept '-' as a trailing option to read stdin. > > Doesn't print usage() after bad options. > > Adds --usage as command line equivalent of --help > > This breaks current usage and possibly other scripts: > > # git diff | ./scripts/get_maintainer.pl - > ./scripts/get_maintainer.pl: file '-' not found Sorry, too early here. What I meant was that it should be able to receive both '-' and simply piped input (i.e., without '-'): git diff | ./scripts/get_maintainer.pl - as well as git diff | ./scripts/get_maintainer.pl IMO. -- Regards/Gruss, Boris. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/