Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754623AbZLYKWk (ORCPT ); Fri, 25 Dec 2009 05:22:40 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753047AbZLYKWk (ORCPT ); Fri, 25 Dec 2009 05:22:40 -0500 Received: from coloquinte.cristau.org ([91.121.16.100]:34884 "EHLO coloquinte.cristau.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752024AbZLYKWj (ORCPT ); Fri, 25 Dec 2009 05:22:39 -0500 X-Greylist: delayed 558 seconds by postgrey-1.27 at vger.kernel.org; Fri, 25 Dec 2009 05:22:39 EST Date: Fri, 25 Dec 2009 11:13:18 +0100 From: Julien Cristau To: Darren Jenkins Cc: David Airlie , dri-devel mailing list , Kernel Janitors , Linux Kernel Mailing List Subject: Re: drivers/gpu/drm/radeon: move a dereference below a NULL test Message-ID: <20091225101318.GQ3003@radis.liafa.jussieu.fr> References: <1261658670.3546.7.camel@ICE-BOX> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1261658670.3546.7.camel@ICE-BOX> X-Operating-System: Linux 2.6.32-trunk-amd64 x86_64 User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 873 Lines: 24 On Thu, Dec 24, 2009 at 23:44:30 +1100, Darren Jenkins wrote: > If a NULL value is possible, the dereference should only occur after the > NULL test. > > Signed-off-by: Darren Jenkins > diff --git a/drivers/gpu/drm/radeon/radeon_irq.c > b/drivers/gpu/drm/radeon/radeon_irq.c > index b79ecc4..2f349a3 100644 > --- a/drivers/gpu/drm/radeon/radeon_irq.c > +++ b/drivers/gpu/drm/radeon/radeon_irq.c > @@ -289,16 +289,16 @@ int radeon_irq_emit(struct drm_device *dev, void > *data, struct drm_file *file_pr Looks like your patches are whitespace-damaged. You'll need to fix your MUA... Cheers, Julien -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/