Subject: Re: [PATCH] [6/6] kfifo: Document everywhere that size has to be
 power of two
From: Stefani Seibold <stefani@seibold.net>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Andi Kleen <andi@firstfloor.org>, linux-kernel@vger.kernel.org,
       akpm@osdl.org
In-Reply-To: <20091227221438.GA16353@core.coreip.homeip.net>
References: <200912271003.631128760@firstfloor.org>
	 <20091227210316.B116EB17C3@basil.firstfloor.org>
	 <1261950632.25298.33.camel@wall-e>
	 <20091227221438.GA16353@core.coreip.homeip.net>
Content-Type: text/plain; charset="ISO-8859-15"
Date: Sun, 27 Dec 2009 23:23:31 +0100
Message-ID: <1261952611.25298.37.camel@wall-e>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1013
Lines: 29

Am Sonntag, den 27.12.2009, 14:14 -0800 schrieb Dmitry Torokhov:
> On Sun, Dec 27, 2009 at 10:50:32PM +0100, Stefani Seibold wrote:
> > Am Sonntag, den 27.12.2009, 22:03 +0100 schrieb Andi Kleen:
> > > On my first try using them I missed that the fifos need to 
> > > be power of two, resulting in a runtime bug. Document that requirement
> > > everywhere (and fix one grammar bug)
> > > 
> > > Signed-off-by: Andi Kleen <ak@linux.intel.com>
> > > 
> > 
> > Acked: Stefani Seibold <Stefani@Seibold.net>
> > 
> 
> Now, does it really _have_ to be this way? For record-oriented
> FIFO's it is customary to be 2*pow(n)*sizeof(rec) which is rarely
> 2*pow(m).
> 

Right. This is why i wrote the new macro base kfifo API, where i am able
to do this in that way.

Stefani


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/