Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752102AbZL1KCP (ORCPT ); Mon, 28 Dec 2009 05:02:15 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751969AbZL1KCO (ORCPT ); Mon, 28 Dec 2009 05:02:14 -0500 Received: from casper.infradead.org ([85.118.1.10]:34159 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750975AbZL1KCN (ORCPT ); Mon, 28 Dec 2009 05:02:13 -0500 Subject: Re: [PATCH 2/2] perf lock: Fix output of tracing lock events From: Peter Zijlstra To: Hitoshi Mitake Cc: mingo@elte.hu, linux-kernel@vger.kernel.org, Paul Mackerras , Frederic Weisbecker In-Reply-To: References: <1260934105-4472-1-git-send-email-mitake@dcl.info.waseda.ac.jp> <1260934105-4472-2-git-send-email-mitake@dcl.info.waseda.ac.jp> <1261041885.27920.110.camel@laptop> Content-Type: text/plain; charset="UTF-8" Date: Mon, 28 Dec 2009 11:01:42 +0100 Message-ID: <1261994502.7135.51.camel@laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1233 Lines: 34 On Sat, 2009-12-26 at 22:43 +0900, Hitoshi Mitake wrote: > > As to removing the waittime, I'm not sure, in this case, yes, but if you > > want some other processing that hooks straight into the tracepoints > > instead of using a logging structure, it might be useful. > > > > Removing that do_div() from there and exposing waittime as u64 in nsec, > > for sure, that do_div() is just silly. > > > > > > > > I was too egoist. perf lock is not an only one user of lock events. > > And I have a suggestion. Adding name of source files and lines of > lock instances may be good thing for human's readability. > How do you think? file:line might be interesting indeed, but I worry about the size of the event entry.. But lets see how that goes. > > Why do we need to have instance resolution? You forgot to answer this question. Is it purely because the waittime computation as done by lockstat is not good enough for you -- should we not fix that instead, that'd benefit more people. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/