Date: Mon, 28 Dec 2009 11:20:28 +0100
From: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
To: Peter =?UTF-8?B?SMO8d2U=?= <PeterHuewe@gmx.de>
Cc: "Hans-Christian Egtvedt" <hans-christian.egtvedt@atmel.com>,
       Nicolas Ferre <nicolas.ferre@atmel.com>,
       Haavard Skinnemoen <hskinnemoen@atmel.com>,
       Andrew Morton <akpm@linux-foundation.org>,
       Peter Ma <pma@mediamatech.com>, linux-kernel@vger.kernel.org,
       linux-mmc@vger.kernel.org
Subject: Re: [PATCH] arch/avr32: Fix build failure for avr32 caused by typo
Message-ID: <20091228112028.5babace2@hskinnemoen-d830>
In-Reply-To: <200912281059.30450.PeterHuewe@gmx.de>
References: <200912252008.45602.PeterHuewe@gmx.de>
	<20091228091318.454c4713@hcegtvedt.norway.atmel.com>
	<200912281059.30450.PeterHuewe@gmx.de>
Organization: Atmel
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 858
Lines: 22

Peter Hüwe <PeterHuewe@gmx.de> wrote:
> Great, thanks for the update.
> The only thing that still catches my eye is that the kzalloc line can fail, so 
> you should perhaps add something like
> if (!slave) {
> 	printk(KERN_ERR "No memory left for at32ap700x: at32_add_device_mc");
> 	goto fail;
> }

I agree, except that this is extremely unlikely to happen, so we should
either drop the printk() or use pr_debug() in order to waste as little
memory as possible in production systems.

I think your first patch is good as it is, so I will apply it. Please
send any additional fixes as a separate patch.

Haavard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/