Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752408AbZL1LHl (ORCPT ); Mon, 28 Dec 2009 06:07:41 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752075AbZL1LHk (ORCPT ); Mon, 28 Dec 2009 06:07:40 -0500 Received: from relay.atmel.no ([80.232.32.139]:50129 "EHLO relay.atmel.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752085AbZL1LHj convert rfc822-to-8bit (ORCPT ); Mon, 28 Dec 2009 06:07:39 -0500 Date: Mon, 28 Dec 2009 12:07:23 +0100 From: Hans-Christian Egtvedt To: Peter =?UTF-8?B?SMO8d2U=?= Cc: Haavard Skinnemoen , Nicolas Ferre , Haavard Skinnemoen , Andrew Morton , Peter Ma , linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org Subject: Re: [PATCH] arch/avr32: Fix build failure for avr32 caused by typo Message-ID: <20091228120723.6a22367e@hcegtvedt.norway.atmel.com> In-Reply-To: <200912281134.36763.PeterHuewe@gmx.de> References: <200912252008.45602.PeterHuewe@gmx.de> <200912281059.30450.PeterHuewe@gmx.de> <20091228112028.5babace2@hskinnemoen-d830> <200912281134.36763.PeterHuewe@gmx.de> Organization: Atmel X-Mailer: Claws Mail 3.7.3 (GTK+ 2.18.3; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1434 Lines: 41 On Mon, 28 Dec 2009 11:34:36 +0100 Peter Hüwe wrote: > Am Montag 28 Dezember 2009 11:20:28 schrieb Haavard Skinnemoen: > > Peter Hüwe wrote: > > > Great, thanks for the update. > > > The only thing that still catches my eye is that the kzalloc line can > > > fail, so you should perhaps add something like > > > if (!slave) { > > > printk(KERN_ERR "No memory left for at32ap700x: at32_add_device_mc"); > > > goto fail; > > > } > > > > I agree, except that this is extremely unlikely to happen, so we should > > either drop the printk() or use pr_debug() in order to waste as little > > memory as possible in production systems. > ok. > I skipped the print message, as no other platform devices will print similar information. If people really need this kind of information they could provide a patch adding it for all the platform devices. > > I think your first patch is good as it is, so I will apply it. Please > > send any additional fixes as a separate patch. > > Okay thanks for applying. > > @Hans: can you create the cleanup patch or should I ? > I'll do it, should arrive here shortly. -- Best regards, Hans-Christian Egtvedt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/