Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752187AbZL1QvU (ORCPT ); Mon, 28 Dec 2009 11:51:20 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751730AbZL1QvT (ORCPT ); Mon, 28 Dec 2009 11:51:19 -0500 Received: from mgw1.diku.dk ([130.225.96.91]:50790 "EHLO mgw1.diku.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751548AbZL1QvS (ORCPT ); Mon, 28 Dec 2009 11:51:18 -0500 Date: Mon, 28 Dec 2009 17:51:15 +0100 (CET) From: Julia Lawall To: H Hartley Sweeten Cc: =?iso-8859-1?Q?Uwe_Kleine-K=F6nig?= , kernel-janitors@vger.kernel.org, linux@arm.linux.org.uk, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: RE: [PATCH 1/5] arch/arm: Correct NULL test In-Reply-To: Message-ID: References: <20091227215106.GA18317@pengutronix.de> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1376 Lines: 42 On Mon, 28 Dec 2009, H Hartley Sweeten wrote: > On Sunday, December 27, 2009 3:08 PM, Julia Lawall wrote: > >>> dbgfs_chan = kmalloc(sizeof(*dbgfs_state) * num_dma_channels, > >>> GFP_KERNEL); > >>> - if (!dbgfs_state) > >>> + if (!dbgfs_chan) > >>> goto err_alloc; > >> Shouldn't the malloc line read: > >> > >> ... = kmalloc(sizeof(*dbgfs_chan) * ...) > >> ^^^^^^^^^^ > >> > >> ? > > > > Good point, thanks. I will send a revised patch. > > Wouldn't this be clearer? > > ... = kmalloc(sizeof(struct dentry) * ...) Documentation/CodingStyle thinks otherwise: "The preferred form for passing a size of a struct is the following: p = kmalloc(sizeof(*p), ...); The alternative form where struct name is spelled out hurts readability and introduces an opportunity for a bug when the pointer variable type is changed but the corresponding sizeof that is passed to a memory allocator is not." And actually, in this case, sizeof(struct dentry) would be wrong, because the type of dbgfs_chan is struct dentry **, not struct dentry *. What is wanted is an array of pointers. julia -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/