DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=virtuousgeek.org;
	h=Received:Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References:X-Mailer:Mime-Version:Content-Type:Content-Transfer-Encoding:X-Identified-User;
	b=VRYoFrusle2zCr1yLTG7UHy1YBETjGLGE+V8t7z30/jMhIRRzTDnzFHteyGPjf6XCtVLid4ysf/5quaM79AjGc4ai1ltiG+QKj5m0rAsiV7isDChub5rvRximCwVZq9d;
Date: Mon, 28 Dec 2009 10:47:41 -0800
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: keithp@keithp.com, Daniel Vetter <daniel.vetter@ffwll.ch>,
       linux-kernel@vger.kernel.org, Dave Airlie <airlied@redhat.com>,
       dri-devel@lists.sourceforge.net
Subject: Re: [BISECTED] drm: random hang since 620f378 "drm: prune modes
 when ..."
Message-ID: <20091228104741.7e5aa82a@jbarnes-x200>
In-Reply-To: <200912211757.08305.arnd@arndb.de>
References: <200912071830.14697.arnd@arndb.de>
	<20091217111359.54f4c518@jbarnes-piketon>
	<200912211606.43789.arnd@arndb.de>
	<200912211757.08305.arnd@arndb.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1377
Lines: 38

On Mon, 21 Dec 2009 17:57:08 +0000
Arnd Bergmann <arnd@arndb.de> wrote:

> On Monday 21 December 2009 16:06:43 Arnd Bergmann wrote:
> > 
> > -       if (IS_G4X(dev)) {
> > -               u16 gcfgc;
> > -
> > -               /* Adjust render clock... */
> > -               pci_read_config_word(dev->pdev, GCFGC, &gcfgc);
> > -
> > -               /* Down to minimum... */
> > -               gcfgc &= ~GM45_GC_RENDER_CLOCK_MASK;
> > -               gcfgc |= GM45_GC_RENDER_CLOCK_266_MHZ;
> > -
> > -               pci_write_config_word(dev->pdev, GCFGC, gcfgc);
> > -       } else if (IS_I965G(dev)) {
> > +       if (IS_I965G(dev)) {
> >                 u16 gcfgc;
> 
> This crashed again immediately, apparently because IS_I965G is a
> superset of IS_G4X (that seems counterintuitive), but not it seems to
> run using this modified version of the patch (half an hour so far).
> 

This code should be completely gone in Eric's drm-intel-next branch
(from
git://git.kernel.org/pub/scm/linux/kernel/git/anholt/drm-intel.git), so
hopefully when that lands upstream (if it hasn't already) things will
be solid for you.

Thanks,
Jesse
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/