Date: Mon, 28 Dec 2009 21:48:48 +0100
From: Pavel Machek <pavel@ucw.cz>
To: Brian Swetland <swetland@google.com>
Cc: Arve Hj?nnev?g <arve@android.com>, Daniel Walker <dwalker@codeaurora.org>,
       kernel list <linux-kernel@vger.kernel.org>,
       linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
       Iliyan Malchev <malchev@google.com>, linux-kernel@codeaurora.org,
       Greg KH <greg@kroah.com>
Subject: Re: tree with htc dream support
Message-ID: <20091228204848.GB1637@ucw.cz>
References: <20091213212504.GD5114@elf.ucw.cz> <d6200be20912142234ia050c67p34fd2672e7248170@mail.gmail.com> <20091227093537.GD11737@elf.ucw.cz> <20091227201514.GA29174@elf.ucw.cz> <a55d774e0912271220p1d102b1dr398e0524c9386702@mail.gmail.com> <20091227203704.GK11737@elf.ucw.cz> <20091227211322.GB29174@elf.ucw.cz> <a55d774e0912271646m1b82687cy427083e64e91e323@mail.gmail.com> <20091227101824.GB1478@ucw.cz> <a55d774e0912281224y7360dfdbu8a251743026bdd28@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <a55d774e0912281224y7360dfdbu8a251743026bdd28@mail.gmail.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1874
Lines: 47

Hi!

> >> > Switch smd code to the version in staging. Something to apply to
> >> > dream/ tree I'd say... and yes, it still works.
> >>
> >> I think we might want to consider leaving at least the core smd code
> >> under mach-msm.
> >
> > In the long run, I agree.
> >
> > In the short run... the code is staging quality, so it should be in
> > staging... and you'll not have to mainain so huge diff. (-20 kLoc).
> 
> The core smd stuff is really not that large.  The central smd.[ch] are
> about 1300 lines, and proc_comm.[ch] are about 400 lines.  Is it
> possible to get some review/feedback as to what's "staging quality"
> about this code so we can clean it up?  I'd rather just fix the
> issues

Just submit it to Daniel W., ccing rmk and l-a-k, and I'm sure you'll
get feedback.

For a start, checkpatch has some mild complains. 

> and get the core stuff in there so clock, power, etc support is there
> for the platform rather than have it live in staging purgatory.
> 
> Since this stuff is integral to mach-msm, required for essential
> operation of the platform, and makes sense to be part of the mach-msm
> codebase, why not just fix it there rather than move it out into
> staging and then back?  I'm not sure what that gains us.

Well, it is in staging now. I just want you to use the existing
version, instead of adding another one.

Of course, getting it into kernel proper would be even better. I'll
gladly help but I did not have yet time/energy to do that.

								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/