Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751676AbZL1UxW (ORCPT ); Mon, 28 Dec 2009 15:53:22 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751475AbZL1UxW (ORCPT ); Mon, 28 Dec 2009 15:53:22 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:55186 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751001AbZL1UxW (ORCPT ); Mon, 28 Dec 2009 15:53:22 -0500 Date: Mon, 28 Dec 2009 21:52:57 +0100 From: Pavel Machek To: Brian Swetland Cc: Arve Hj?nnev?g , Daniel Walker , kernel list , linux-arm-kernel , Iliyan Malchev , linux-kernel@codeaurora.org, Greg KH Subject: Re: tree with htc dream support Message-ID: <20091228205257.GA1862@ucw.cz> References: <20091227093537.GD11737@elf.ucw.cz> <20091227201514.GA29174@elf.ucw.cz> <20091227203704.GK11737@elf.ucw.cz> <20091227211322.GB29174@elf.ucw.cz> <20091227101824.GB1478@ucw.cz> <20091228204848.GB1637@ucw.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091228204848.GB1637@ucw.cz> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1455 Lines: 36 On Mon 2009-12-28 21:48:48, Pavel Machek wrote: > Hi! > > > >> > Switch smd code to the version in staging. Something to apply to > > >> > dream/ tree I'd say... and yes, it still works. > > >> > > >> I think we might want to consider leaving at least the core smd code > > >> under mach-msm. > > > > > > In the long run, I agree. > > > > > > In the short run... the code is staging quality, so it should be in > > > staging... and you'll not have to mainain so huge diff. (-20 kLoc). > > > > The core smd stuff is really not that large. The central smd.[ch] are > > about 1300 lines, and proc_comm.[ch] are about 400 lines. Is it > > possible to get some review/feedback as to what's "staging quality" > > about this code so we can clean it up? I'd rather just fix the > > issues > > Just submit it to Daniel W., ccing rmk and l-a-k, and I'm sure you'll > get feedback. > > For a start, checkpatch has some mild complains. BTW if would be cool to fix style in the staging/, then do git mv, so that cleanups are clearly separated/changelogged in kernel proper... -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/