To: linux-kernel@vger.kernel.org
From: Andres Salomon <dilinger@queued.net>
Subject: Re: [PATCH 12/14] USB: oti6858: fix DMA buffer on stack
Date: Mon, 28 Dec 2009 17:46:19 -0500
Message-ID: <20091228174619.3c5b2132@mycelium.queued.net>
References: <1262037718-31424-1-git-send-email-jhovold@gmail.com>
	<1262037718-31424-13-git-send-email-jhovold@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
In-Reply-To: <1262037718-31424-13-git-send-email-jhovold@gmail.com>
Cc: linux-usb@vger.kernel.org
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 940
Lines: 23

On Mon, 28 Dec 2009 23:01:56 +0100
Johan Hovold <jhovold@gmail.com> wrote:

[...]
> diff --git a/drivers/usb/serial/oti6858.c
> b/drivers/usb/serial/oti6858.c index c644e26..2ae97e7 100644
> --- a/drivers/usb/serial/oti6858.c
> +++ b/drivers/usb/serial/oti6858.c
> @@ -302,7 +302,7 @@ void send_data(struct work_struct *work)
>  	struct usb_serial_port *port = priv->port;
>  	int count = 0, result;
>  	unsigned long flags;
> -	unsigned char allow;
> +	u8 *allow;
>  
>  	dbg("%s(port = %d)", __func__, port->number);
>  

Erm, am I missing something here?  You're removing a 1 byte
stack variable and replacing it with a 4 byte (pointer) stack
variable?  What's the point of that, exactly?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/