Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752517AbZL1X1Y (ORCPT ); Mon, 28 Dec 2009 18:27:24 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752146AbZL1X1X (ORCPT ); Mon, 28 Dec 2009 18:27:23 -0500 Received: from exprod6og103.obsmtp.com ([64.18.1.185]:56487 "HELO exprod6og103.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751975AbZL1X1X convert rfc822-to-8bit (ORCPT ); Mon, 28 Dec 2009 18:27:23 -0500 X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Subject: [PATCH] drivers/net/usb/rtl8150.c: use %pM to shown MAC address Date: Mon, 28 Dec 2009 18:27:27 -0500 Message-ID: X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [PATCH] drivers/net/usb/rtl8150.c: use %pM to shown MAC address Thread-Index: AcqIFVFiMy2nL7NbTbWZW1TNDNvpiw== From: "H Hartley Sweeten" To: , Cc: "David Miller" X-OriginalArrivalTime: 28 Dec 2009 23:27:21.0462 (UTC) FILETIME=[4DCF9160:01CA8815] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1292 Lines: 39 Use the %pM kernel extension to display the MAC address. Signed-off-by: H Hartley Sweeten Cc: David S. Miller --- diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c index f14d225..dfc7e9f 100644 --- a/drivers/net/usb/rtl8150.c +++ b/drivers/net/usb/rtl8150.c @@ -313,20 +313,17 @@ static int rtl8150_set_mac_address(struct net_device *netdev, void *p) { struct sockaddr *addr = p; rtl8150_t *dev = netdev_priv(netdev); - int i; if (netif_running(netdev)) return -EBUSY; memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len); - dbg("%s: Setting MAC address to ", netdev->name); - for (i = 0; i < 5; i++) - dbg("%02X:", netdev->dev_addr[i]); - dbg("%02X\n", netdev->dev_addr[i]); + dbg("%s: Setting MAC address to %pM\n", netdev->name, netdev->dev_addr); /* Set the IDR registers. */ set_registers(dev, IDR, netdev->addr_len, netdev->dev_addr); #ifdef EEPROM_WRITE { + int i; u8 cr; /* Get the CR contents. */ get_registers(dev, CR, 1, &cr); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/