DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-type:content-disposition:in-reply-to:user-agent;
        b=wGBVvx9DFta7ZzL5VrE2/iIuLqbaKAwZ+3tTIOgrFHgO8kzC6lA42LJZFjAFqHGFq0
         FH1EgV7sFmCBoi3HAngc+mAHykfqFHvYFWrmG5QTGPvle0Vk6Ah83RtCWhRPTsGEBjdK
         mEOT6y8WQ2g2BrOGMbP9ellp2LFtclUQlfzyw=
Date: Tue, 29 Dec 2009 23:02:35 +0800
From: =?utf-8?Q?Am=C3=A9rico?= Wang <xiyou.wangcong@gmail.com>
To: hooanon05@yahoo.co.jp
Cc: viro@ZenIV.linux.org.uk, linux-kernel@vger.kernel.org
Subject: Re: Q. d_alloc() in pipe(2)
Message-ID: <20091229150235.GA2927@hack>
References: <20021.1262066120@jrobl>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20021.1262066120@jrobl>
User-Agent: Mutt/1.5.19 (2009-01-05)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 688
Lines: 23

On Tue, Dec 29, 2009 at 02:55:20PM +0900, hooanon05@yahoo.co.jp wrote:
>
>In pipe(2), create_write_pipe() creates a dentry by
>	struct qstr name = { .name = "" };
>	d_alloc(root, &name);
>
>But d_alloc() refers name->len which is uninitialized.

Well, it is initialized to 0. :)

>Isn't it better to replace d_alloc() by d_alloc_name(root, "")?
>

Maybe not, they totally equal in this case, IMO.

-- 
Live like a child, think like the god.
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/