Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752288AbZL2UEN (ORCPT ); Tue, 29 Dec 2009 15:04:13 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752156AbZL2UEL (ORCPT ); Tue, 29 Dec 2009 15:04:11 -0500 Received: from mgw2.diku.dk ([130.225.96.92]:36286 "EHLO mgw2.diku.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751694AbZL2UEI (ORCPT ); Tue, 29 Dec 2009 15:04:08 -0500 Date: Tue, 29 Dec 2009 21:04:05 +0100 (CET) From: Julia Lawall To: Rolf Eike Beer Cc: James.Bottomley@suse.de, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 3/5] drivers/scsi : Correct the size argument to kmalloc In-Reply-To: <200912292102.43373.eike-kernel@sf-tec.de> Message-ID: References: <200912292102.43373.eike-kernel@sf-tec.de> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 712 Lines: 20 On Tue, 29 Dec 2009, Rolf Eike Beer wrote: > Julia Lawall wrote: > > From: Julia Lawall > > > > In each case, the destination of the allocation has type struct **, so the > > elements of the array should have pointer type, not structure type. > > Maybe they should even by kcalloc'ed? I thought about that, but in response to another patch someone seemed to think kcalloc was not very useful. But I can certainly change it in this case. julia -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/