Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752044AbZL3DLF (ORCPT ); Tue, 29 Dec 2009 22:11:05 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751800AbZL3DLE (ORCPT ); Tue, 29 Dec 2009 22:11:04 -0500 Received: from vps2.mechanicalrealm.com ([66.216.20.21]:59809 "EHLO zinan.dashjr.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751646AbZL3DLD (ORCPT ); Tue, 29 Dec 2009 22:11:03 -0500 From: "Luke-Jr" To: Kalle Valo Subject: Re: [PATCH] OMAP2: add USB platform data and initialization for Nokia N800 and N810 Date: Tue, 29 Dec 2009 21:10:27 -0600 User-Agent: KMail/1.12.3 (Linux/2.6.32-gentoo; KDE/4.3.3; x86_64; ; ) Cc: "linux-kernel@vger.kernel.org" , "linux-omap@vger.kernel.org" , "Balbi Felipe \(Nokia-D\/Helsinki\)" References: <200912290152.16357.luke@dashjr.org> <873a2uxip9.fsf@purkki.valot.fi> <200912291505.51230.luke@dashjr.org> In-Reply-To: <200912291505.51230.luke@dashjr.org> X-PGP-Key-Fingerprint: CE5A D56A 36CC 69FA E7D2 3558 665F C11D D53E 9583 X-PGP-Key-ID: 665FC11DD53E9583 X-PGP-Keyserver: x-hkp://subkeys.pgp.bet MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200912292110.42122.luke@dashjr.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1275 Lines: 28 On Tuesday 29 December 2009 03:05:46 pm Luke-Jr wrote: > The last-working N8x0 support (Linux-OMAP 2.6.30-rc8) required 1706 lines > of platform data and initialization, split up into 6 files: Upon trying to debug my non-working keyboard, I learned that the status of mainlining is actually worse off than I thought, and my "last 2.6.30-rc8 working" revision was actually already missing platform data. It seems logical from looking at the code needed to divide the board into at least 5 files (line number estimates based on old code): 460 board-n8x0-common.c 175 board-n800.c (FM radio, touchscreen) 260 board-n810.c (keyboard, light sensor, LEDs, touchscreen) 600 board-n8x0-multimedia.c (camera, audio, DSP) 725 board-n8x0-storage.c (flash, MMC) 120 board-n8x0-lcd.c On that topic, is there a reason the newer code is under a unified "N8x0" config option instead of the split N800/N810 that was used for the old code, or is that simply a symptom of the currently-supported features all being common? Luke -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/