Date: Wed, 30 Dec 2009 12:29:20 +0100 (CET)
From: Julia Lawall <julia@diku.dk>
To: Joe Perches <joe@perches.com>
Cc: Rolf Eike Beer <eike-kernel@sf-tec.de>, James.Bottomley@suse.de,
       linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
       kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 3/5] drivers/scsi : Correct the size argument to kmalloc
In-Reply-To: <1262121796.1888.190.camel@Joe-Laptop.home>
Message-ID: <Pine.LNX.4.64.0912301228540.23134@ask.diku.dk>
References: <Pine.LNX.4.64.0912292015420.4001@ask.diku.dk> 
 <200912292102.43373.eike-kernel@sf-tec.de>  <Pine.LNX.4.64.0912292103180.4001@ask.diku.dk>
 <1262121796.1888.190.camel@Joe-Laptop.home>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1086
Lines: 27

On Tue, 29 Dec 2009, Joe Perches wrote:

> On Tue, 2009-12-29 at 21:04 +0100, Julia Lawall wrote:
> > On Tue, 29 Dec 2009, Rolf Eike Beer wrote:
> > > Julia Lawall wrote:
> > > > From: Julia Lawall <julia@diku.dk>
> > > > In each case, the destination of the allocation has type struct **, so the
> > > > elements of the array should have pointer type, not structure type.
> > > Maybe they should even by kcalloc'ed?
> > I thought about that, but in response to another patch someone seemed to 
> > think kcalloc was not very useful.  But I can certainly change it in this 
> > case.
> 
> I think kcalloc is useful and should be used when the
> allocated array of elements needs to be zeroed.
> 
> It appears the uses in 1/5 and 3/5 don't need it but
> maybe patch 2/5 and 4/5 should use kcalloc.

I will look into changing them too.

julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/