Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Wed, 10 Apr 2002 08:22:58 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Wed, 10 Apr 2002 08:22:58 -0400 Received: from mail.sonytel.be ([193.74.243.200]:13442 "EHLO mail.sonytel.be") by vger.kernel.org with ESMTP id ; Wed, 10 Apr 2002 08:22:56 -0400 Date: Wed, 10 Apr 2002 14:22:12 +0200 (MEST) From: Geert Uytterhoeven To: Benjamin Herrenschmidt cc: Peter Horton , Linux Kernel Development Subject: Re: [PATCH] Radeon frame buffer driver In-Reply-To: <20020410130106.1191@mailhost.mipsys.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 10 Apr 2002 benh@kernel.crashing.org wrote: > >> The colour map is only used by the kernel and the kernel only uses 16 > >> entries so there isn't any reason to waste memory by making it any > >> larger. I checked a few other drivers and they do the same (aty128fb for > >> one). > > > >However, this change will make the driver not save/restore all color map > >entries on VC switch in graphics mode. > > Geert, didn't you tell me the fbdev apps were responsible for restoring > their cmap on console switch ? Probably not (unless you can quote me on that :-) The color map is saved/restored in radeonfb_switch(). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/