Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753199AbZL3SDG (ORCPT ); Wed, 30 Dec 2009 13:03:06 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753119AbZL3SDE (ORCPT ); Wed, 30 Dec 2009 13:03:04 -0500 Received: from exprod6og107.obsmtp.com ([64.18.1.208]:42021 "HELO exprod6og107.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752486AbZL3SDC convert rfc822-to-8bit (ORCPT ); Wed, 30 Dec 2009 13:03:02 -0500 X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Subject: RE: [PATCH] ep93xx_eth.c: general cleanup Date: Wed, 30 Dec 2009 13:03:00 -0500 Message-ID: In-Reply-To: <20091223.141458.193725880.davem@davemloft.net> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [PATCH] ep93xx_eth.c: general cleanup Thread-Index: AcqEHVyYIX0lQ75XTjiZoV/EvAzapQFXEN2w References: <20091216183200.GN1819@mail.wantstofly.org> <20091223.141458.193725880.davem@davemloft.net> From: "H Hartley Sweeten" To: "Lennert Buytenhek" Cc: "David Miller" , , , X-OriginalArrivalTime: 30 Dec 2009 18:02:59.0958 (UTC) FILETIME=[52AD3960:01CA897A] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1820 Lines: 51 On Wednesday, December 23, 2009 3:15 PM, David Miller wrote: > From: "H Hartley Sweeten" > Date: Wed, 16 Dec 2009 13:34:55 -0500 > >> Wednesday, December 16, 2009 11:32 AM, Lennert Buytenhek wrote: >>> On Wed, Dec 16, 2009 at 01:18:13PM -0500, H Hartley Sweeten wrote: >>> >>>> V3 - Change pr_fmt() as suggested by Joe Perches >>>> Don't remove DRV_MODULE_NAME and DRV_MODULE_VERSION >>>> Don't remove the message in ep93xx_eth_init_module() >>> >>> That's not what I meant, but alright, as you prefer. >> >> Guess my parser is off line today.... ;-) >> >> What did you mean? > > This patch also doesn't apply to current sources, so if you > could also please respin this once you've resolved the feedback > that would be great. Lennert, Since I need to respin this patch what did you mean by this comment? On Wednesday, December 16, 2009 11:09 AM, Lennert Buytenhek wrote: > On Wed, Dec 16, 2009 at 01:06:10PM -0500, H Hartley Sweeten wrote: > >>>> General cleanup of the ep93xx_eth driver. >>> >>> Apart from keeping DRV_MODULE_NAME and DRV_MODULE_VERSION, I have >>> no strong opinion about this one way or the other. So I guess that >>> means ACK. >> >> I will add back the DRV_MODULE_NAME and DRV_MODULE_VERSION and repost. >> >> What about the message in ep93xx_eth_init_module()? Would you prefer >> that one to stay? > > Most drivers I'm familiar with print a version message when they are > first instantiated -- perhaps that makes more sense. I will wait for your reply before updating the patch. Thanks, Hartley -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/