Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753071AbZL3TaW (ORCPT ); Wed, 30 Dec 2009 14:30:22 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752807AbZL3TaV (ORCPT ); Wed, 30 Dec 2009 14:30:21 -0500 Received: from mail.parknet.co.jp ([210.171.160.6]:57696 "EHLO mail.parknet.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752574AbZL3TaV (ORCPT ); Wed, 30 Dec 2009 14:30:21 -0500 From: OGAWA Hirofumi To: Kay Sievers Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Miklos Szeredi Subject: Re: [PATCH 02/10] vfs: get_sb_single() - do not pass options twice References: <20091223194955.GB18101@kroah.com> <1261597963-18323-2-git-send-email-gregkh@suse.de> <87my14h9vo.fsf@devron.myhome.or.jp> Date: Thu, 31 Dec 2009 04:30:11 +0900 In-Reply-To: (Kay Sievers's message of "Wed, 30 Dec 2009 19:05:58 +0100") Message-ID: <87hbr8w98c.fsf@devron.myhome.or.jp> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1410 Lines: 32 Kay Sievers writes: > On Sun, Dec 27, 2009 at 13:36, OGAWA Hirofumi > wrote: >>> Filesystem code usually destroys the option buffer while >>> parsing it. This leads to errors when the same buffer is >>> passed twice. In case we fill a new superblock do not call >>> remount. > >> This breaks the historical behavior. Several users of get_sb_single() is >> parse data only on ->remount_fs. Well, ok, I like new behavior actually. >> But we need to convert to new behavior such users. >> >> I've listed all possibly affected users up (if I'm not missing). This >> means, using both data on ->fill_super and ->remount_fs is devtmpfs >> only. And capifs, usbfs, devpts would be needed the patch. > > Hmm, these filesystem are probably not going to overwrite their own > default options with their own special parameters to parse when they > allocate their superblock. That would be pretty weird, wouldn't it? > Seems they currently don't even pass "data" pointer around at that > time. Oops, I was missing that those all fs was using kern_mount(). Sorry for noise. -- OGAWA Hirofumi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/