Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753706AbZL3U7h (ORCPT ); Wed, 30 Dec 2009 15:59:37 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753407AbZL3U7g (ORCPT ); Wed, 30 Dec 2009 15:59:36 -0500 Received: from mail.parknet.co.jp ([210.171.160.6]:54253 "EHLO mail.parknet.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753227AbZL3U7f (ORCPT ); Wed, 30 Dec 2009 15:59:35 -0500 From: OGAWA Hirofumi To: Marvin Cc: Linux Kernel Mailing List Subject: Re: vfs related crash in 2.6.33-rc2 References: <200912301733.19077.marvin24@gmx.de> <87637oi6v8.fsf@devron.myhome.or.jp> <200912302144.36718.marvin24@gmx.de> Date: Thu, 31 Dec 2009 05:59:32 +0900 In-Reply-To: <200912302144.36718.marvin24@gmx.de> (Marvin's message of "Wed, 30 Dec 2009 21:44:36 +0100") Message-ID: <87637omb4b.fsf@devron.myhome.or.jp> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1847 Lines: 61 Marvin writes: >> Marvin writes: >> > Hi, >> > >> > I'm getting a lot of these: >> > >> > kernel: general protection fault: 0000 [#1] SMP >> > kernel: last sysfs file: /sys/devices/pci0000:00/0000:00:18.3/modalias >> > kernel: CPU 0 >> > kernel: Pid: 12177, comm: packagekitd Not tainted 2.6.33-rc2 #1 >> > ... >> > >> > filesystem is ext4 (in case it matters). >> >> BTW, are you using nfs client on this machine? >> > > um - yes, now that I think about it... I killed a nfs umount process (because of an > offline server) shortly before the oopses started to fire. OK. Probably, this oops would be same with one which happened on my machine recently. That path in patch corrupts dcache hash, so it can be the cause of strange behavior or oops on dcache hash. If so, the attached patch would fix it. Thanks. -- OGAWA Hirofumi Recent change is missing to update "rehash". With that change, it will become the cause of adding dentry to hash twice. This explains the reason of Oops (dereference the freed dentry in __d_lookup()) on my machine. Signed-off-by: OGAWA Hirofumi --- fs/nfs/dir.c | 1 + 1 file changed, 1 insertion(+) diff -puN fs/nfs/dir.c~nfs-d_rehash-fix fs/nfs/dir.c --- linux-2.6/fs/nfs/dir.c~nfs-d_rehash-fix 2009-12-28 06:18:09.000000000 +0900 +++ linux-2.6-hirofumi/fs/nfs/dir.c 2009-12-28 06:18:16.000000000 +0900 @@ -1615,6 +1615,7 @@ static int nfs_rename(struct inode *old_ goto out; new_dentry = dentry; + rehash = NULL; new_inode = NULL; } } _ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/