Return-Path: <linux-kernel-owner+w=401wt.eu-S1752926AbZLaSPS@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752926AbZLaSPS (ORCPT <rfc822;w@1wt.eu>);
	Thu, 31 Dec 2009 13:15:18 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752871AbZLaSPR
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Thu, 31 Dec 2009 13:15:17 -0500
Received: from thunk.org ([69.25.196.29]:40078 "EHLO thunker.thunk.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752863AbZLaSPQ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 31 Dec 2009 13:15:16 -0500
Date: Thu, 31 Dec 2009 13:15:10 -0500
From: tytso@mit.edu
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
       Kernel Testers List <kernel-testers@vger.kernel.org>,
       Dmitry Torokhov <dmitry.torokhov@gmail.com>,
       Gene Heskett <gene.heskett@verizon.net>, okias <d.okias@gmail.com>
Subject: Re: [Bug #14936] kernel BUG at fs/ext4/inode.c:1063 if attempted
 to use non-ext4 partition with ext4
Message-ID: <20091231181510.GF828@thunk.org>
Mail-Followup-To: tytso@mit.edu, "Rafael J. Wysocki" <rjw@sisk.pl>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Kernel Testers List <kernel-testers@vger.kernel.org>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Gene Heskett <gene.heskett@verizon.net>, okias <d.okias@gmail.com>
References: <LptzGUUXbTK.A.MSF.ymhOLB@chimera>
 <20091229165712.GH4429@thunk.org>
 <20091230190120.GQ4429@thunk.org>
 <200912302252.12140.rjw@sisk.pl>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200912302252.12140.rjw@sisk.pl>
User-Agent: Mutt/1.5.20 (2009-06-14)
X-SA-Exim-Connect-IP: <locally generated>
X-SA-Exim-Mail-From: tytso@thunk.org
X-SA-Exim-Scanned: No (on thunker.thunk.org); SAEximRunCond expanded to false
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1489
Lines: 32

On Wed, Dec 30, 2009 at 10:52:12PM +0100, Rafael J. Wysocki wrote:
> > I'm working on a fix, and have a proposed patch.  See the thread on
> > linux-ext4 here:
> > 
> > http://marc.info/?l=linux-kernel&m=126219515024315&w=2
> > 
> > This patch also fixes the dq_claim_space kerneloops problem as
> > well....
> 
> Thanks, I've added your patch to the Bugzilla entry.

This patch has been merged to mainline.  I'm working on improving
things so that we don't lose performance by unnecessarily forcing
delalloc blocks out to disk when the (wildly overestimated) number of
required metadata blocks approaches the user's remaining quota or
remaining free space on disk, but the fundamental fix is in mainline.

(The performance hit was something I knew about when I pushed the
patch to Linus, but after discussing things with Eric Sandeen, we
figured that for users who were converting from ext3, which didn't
have delayed allocation support at all, even with the performance hit
when the user approached the quota limit, ext4 with delalloc+quota was
still better than ext3 --- and I wanted a fix in mainline ASAP.
Fortunately, it's not going to be that hard make the required metadata
much more accurate.)

	     	      	       	       	    - Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/