To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: backwards busy wait using "time_before()"??
From: Andi Kleen <andi@firstfloor.org>
References: <alpine.LFD.2.00.0912311136560.3596@localhost>
Date: Fri, 01 Jan 2010 16:17:07 +0100
In-Reply-To: <alpine.LFD.2.00.0912311136560.3596@localhost> (Robert P. J. Day's message of "Thu, 31 Dec 2009 11:40:42 -0500 (EST)")
Message-ID: <87tyv57t3g.fsf@basil.nowhere.org>
User-Agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/22.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 752
Lines: 23

"Robert P. J. Day" <rpjday@crashcourse.ca> writes:

>                 cpu_relax();                                            \
>         } while (time_before(end_jiffies, jiffies));                    \
>         succeeded;                                                      \
>         })
>
>
>   is it just me, or do those arguments to time_before() look
> backwards?

Yes it looks backwards. The timeout path probably has been never
tested.

-Andi

-- 
ak@linux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/