DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-type:content-disposition:in-reply-to:user-agent;
        b=b37GZfGLcjlD+v4sr1dV1RkGp5Vx6y1+BEgQJRuINatl2gX3syqy5jKtrChlAprwT6
         CKdNnmap/q0D9fVd01CheCC5wUE+a9WRt/BHdeA4ds4Q741VpVQz0mELW8krOJ9y63FG
         tHnhd3xXpm2LPMHwN9JJxpUn+5Q8SH0ctmwF4=
Date: Sat, 2 Jan 2010 11:30:13 -0800
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Arjan van de Ven <arjan@infradead.org>
Cc: tglx@linutronix.de, Andi Kleen <andi@firstfloor.org>,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] timer: Introduce mod_timer_msec()
Message-ID: <20100102193013.GA2232@core.coreip.homeip.net>
References: <20100102104853.28505e39@infradead.org>
 <20100102105012.40d678f2@infradead.org>
 <877hs0724u.fsf@basil.nowhere.org>
 <20100102112108.574396fd@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20100102112108.574396fd@infradead.org>
User-Agent: Mutt/1.5.20 (2009-08-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1200
Lines: 33

On Sat, Jan 02, 2010 at 11:21:08AM -0800, Arjan van de Ven wrote:
>  /**
> + * mod_timer_msec - modify a timer's timeout, using relative milliseconds
> + * @timer: the timer to be modified
> + * @delay_ms: the desired minimum delay in milliseconds
> + *
> + * Changes the timeout of a timer similar to mod_timer().
> + *
> + * mod_timer_msec() takes relative milliseconds rather than absolute
> + * jiffies as argument.
> + *
> + * The function returns whether it has modified a pending timer or not.
> + * (ie. mod_timer_msec() of an inactive timer returns 0, mod_timer_msec() of
> + * an active timer returns 1.)
> + */
> +int mod_timer_msec(struct timer_list *timer, unsigned long delay_ms)
> +{
> +	return mod_timer(timer, jiffies + msecs_to_jiffies(delay_ms));
> +}
> +EXPORT_SYMBOL(mod_timer_msec);

I wonder why isn't this an inline function? Seems tiny enough...  Other
than that -  I'll gladly take input conversion patches.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/