Date: Sat, 2 Jan 2010 11:19:46 -0800
From: Arjan van de Ven <arjan@infradead.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org
Subject: Re: users of mod_timer_msec()
Message-ID: <20100102111946.045611b6@infradead.org>
In-Reply-To: <877hs0724u.fsf@basil.nowhere.org>
References: <20100102104853.28505e39@infradead.org>
	<20100102105012.40d678f2@infradead.org>
	<877hs0724u.fsf@basil.nowhere.org>
Organization: Intel
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 969
Lines: 34

On Sat, 02 Jan 2010 20:11:45 +0100
Andi Kleen <andi@firstfloor.org> wrote:

> Arjan van de Ven <arjan@infradead.org> writes:
> 
> >  	emp->activity++;
> >  	if (!timer_pending(&emp->timer))
> > -		mod_timer(&emp->timer, jiffies +
> > msecs_to_jiffies(10));
> > +		mod_timer_msec(&emp->timer, 10);
> 
> ... but your original patch does
> 
> +int mod_timer_msec(struct timer_list *timer, unsigned long delay_ms)
> +{
> +       return mod_timer(timer, msecs_to_jiffies(delay_ms));
> 

eh last minute typo

this is supposed to be jiffies + msecs_to_jiffies()

good catch; thanks!


-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/