Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750969Ab0ACGDx (ORCPT ); Sun, 3 Jan 2010 01:03:53 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750880Ab0ACGDx (ORCPT ); Sun, 3 Jan 2010 01:03:53 -0500 Received: from hera.kernel.org ([140.211.167.34]:36854 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750855Ab0ACGDw (ORCPT ); Sun, 3 Jan 2010 01:03:52 -0500 Message-ID: <4B4033AF.9050101@kernel.org> Date: Sun, 03 Jan 2010 15:05:35 +0900 From: Tejun Heo User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091130 SUSE/3.0.0-1.1.1 Thunderbird/3.0 MIME-Version: 1.0 To: "Eric W. Biederman" CC: Linus Torvalds , KOSAKI Motohiro , Borislav Petkov , David Airlie , Linux Kernel Mailing List , Greg KH , Al Viro , Dmitry Torokhov Subject: Re: drm_vm.c:drm_mmap: possible circular locking dependency detected References: <20091226094504.GA6214@liondog.tnic> <20091228092712.AA8C.A69D9226@jp.fujitsu.com> <4B3EB687.7000005@kernel.org> <4B3FE586.7020109@kernel.org> <4B4024A5.1020704@kernel.org> In-Reply-To: X-Enigmail-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1053 Lines: 26 Hello, On 01/03/2010 02:38 PM, Eric W. Biederman wrote: >> How about simply introducing an interface to mark sysfs nodes which >> don't require active reference counting and using them on those nodes? > > That might work. However it does not seem to address the case of > bond_sysfs, especially with someone doing rmmod bonding. Ah... okay, now I remember this. Yeah, I ripped off module ref counting from sysfs ops. I completely forgot about that and was thinking we still had module ref counting on sysfs ops. The logical thing to do would be restoring module ref counting on sysfs ops which won't go through active ref counting. ie. Let the interface which switch off active ref counting require module owner so that it uses module ref counting instead of active ref counting. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/