Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752936Ab0ACQsb (ORCPT ); Sun, 3 Jan 2010 11:48:31 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752865Ab0ACQsa (ORCPT ); Sun, 3 Jan 2010 11:48:30 -0500 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:56263 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752435Ab0ACQs3 (ORCPT ); Sun, 3 Jan 2010 11:48:29 -0500 Date: Sun, 3 Jan 2010 16:44:14 +0000 From: Russell King - ARM Linux To: Hui Zhu Cc: saeed bishara , Catalin Marinas , Nicolas Pitre , Ralf Baechle , David Daney , Tomaso Paoletti , Chris Dearman , Paul Gortmaker , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Frederic Weisbecker , Alexey Dobriyan , Brian Gerst , Tejun Heo , Rusty Russell , Andrew Morton , Steven Rostedt , Greg Kroah-Hartman , "Paul E. McKenney" , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, Coly Li Subject: Re: [PATCH] stack2core: show stack message and convert it to core file when kernel die Message-ID: <20100103164414.GB21156@n2100.arm.linux.org.uk> References: <20100103160313.GA21156@n2100.arm.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1635 Lines: 33 On Mon, Jan 04, 2010 at 12:30:20AM +0800, Hui Zhu wrote: > This S2C: message just for program s2c. > s2c can convert it to a core file. Then gdb can do a clear analyse > with this file. > Then you can get more message than current we can get. I understand that. What I'm saying is that all the additional noise you're causing the kernel to create is just a pure duplication of what we already dump. Oops dumps are already noisy enough - especially if they cause a panic at the end (where you end up with two backtraces.) We do not need even more noise caused by needless duplication. You can get everything you need already from the kernel. On ARM, we already dump out all the registers and the _full_ stack. There is no need for you to implement your own register dumping code and full stack dump on top of that again. So, I'm not going to accept your patch for the ARM kernel. Please use what's already provided - it's more than adequate. By doing so, you don't penalise those of us who want to read the raw oopses. Talking about noisy oopses, I'm getting one with 2.6.33-rc2 on 'poweroff' shutdown. No idea what it is because most of it's scrolled off the top of the screen and I can't scroll back. Not bothered about it at the moment. What it does illustrate though is why making things too noisy when problems occur makes it _more_ difficult to find out what went wrong. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/