Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752867Ab0ACXvx (ORCPT ); Sun, 3 Jan 2010 18:51:53 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752792Ab0ACXvv (ORCPT ); Sun, 3 Jan 2010 18:51:51 -0500 Received: from fgwmail7.fujitsu.co.jp ([192.51.44.37]:51220 "EHLO fgwmail7.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752717Ab0ACXvv (ORCPT ); Sun, 3 Jan 2010 18:51:51 -0500 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 Date: Mon, 4 Jan 2010 08:48:38 +0900 From: KAMEZAWA Hiroyuki To: KOSAKI Motohiro Cc: LKML , linux-mm , Andrew Morton , Balbir Singh , Mel Gorman Subject: Re: [PATCH 1/4] vmstat: remove zone->lock from walk_zones_in_node Message-Id: <20100104084838.fd229ec0.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20091228164451.A687.A69D9226@jp.fujitsu.com> References: <20091228164451.A687.A69D9226@jp.fujitsu.com> Organization: FUJITSU Co. LTD. X-Mailer: Sylpheed 2.7.1 (GTK+ 2.10.14; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 862 Lines: 20 On Mon, 28 Dec 2009 16:47:22 +0900 (JST) KOSAKI Motohiro wrote: > The zone->lock is one of performance critical locks. Then, it shouldn't > be hold for long time. Currently, we have four walk_zones_in_node() > usage and almost use-case don't need to hold zone->lock. > > Thus, this patch move locking responsibility from walk_zones_in_node > to its sub function. Also this patch kill unnecessary zone->lock taking. > > Cc: Mel Gorman > Signed-off-by: KOSAKI Motohiro Reviewd-by: KAMEZAWA Hiroyuki -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/