Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752926Ab0ADEnY (ORCPT ); Sun, 3 Jan 2010 23:43:24 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752834Ab0ADEnX (ORCPT ); Sun, 3 Jan 2010 23:43:23 -0500 Received: from acsinet12.oracle.com ([141.146.126.234]:59551 "EHLO acsinet12.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752587Ab0ADEnX (ORCPT ); Sun, 3 Jan 2010 23:43:23 -0500 Date: Sun, 3 Jan 2010 20:42:30 -0800 From: Randy Dunlap To: Phillip Lougher Cc: Stephen Rothwell , linux-next@vger.kernel.org, LKML , Michal Marek , akpm Subject: Re: [PATCH -next] libs: force lzma_wrapper to be retained Message-Id: <20100103204230.a85ae137.randy.dunlap@oracle.com> In-Reply-To: <4B3FEB1B.7040106@lougher.demon.co.uk> References: <20100101120737.94d4acc4.sfr@canb.auug.org.au> <20100101183344.398f2538.randy.dunlap@oracle.com> <4B3FEB1B.7040106@lougher.demon.co.uk> Organization: Oracle Linux Eng. X-Mailer: Sylpheed 2.7.1 (GTK+ 2.12.0; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Source-IP: acsmt354.oracle.com [141.146.40.154] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090203.4B4171D5.0110:SCFMA4539814,ss=1,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1264 Lines: 38 On Sun, 03 Jan 2010 00:55:55 +0000 Phillip Lougher wrote: > Randy Dunlap wrote: > > From: Randy Dunlap > > > > When CONFIG_SQUASHFS=m and CONFIG_DECOMPRESS_LZMA=m, decompress_lzma > > is built but then discarded from the library because no built-in code > > uses it, so change it from a lib- to an obj- to force it to be kept > > in the library. > > > > ERROR: "unlzma" [fs/squashfs/squashfs.ko] undefined! > > > > Thanks for fixing this, I should have spotted it in my various > config tests but didn't. I could add this to my squashfs-next patches > to stop the linux-next tree breakage, however, should it go into > Michal's kbuild -next tree instead? You can/should go ahead and include this patch, I think. > This patch raises a small additional issue, why is DECOMPRESS_LZMA > (and DECOMPRESS_GZIP/DECOMPRESS_BZIP2) and defined as tristate? > None of the above compressors can be built as modules. No idea. Sounds like a potential problem. > Regards > > Phillip --- ~Randy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/