Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753329Ab0ADHMc (ORCPT ); Mon, 4 Jan 2010 02:12:32 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753285Ab0ADHMb (ORCPT ); Mon, 4 Jan 2010 02:12:31 -0500 Received: from gwu.lbox.cz ([62.245.111.132]:41815 "EHLO gwu.lbox.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753280Ab0ADHMa (ORCPT ); Mon, 4 Jan 2010 02:12:30 -0500 Date: Mon, 4 Jan 2010 08:12:17 +0100 From: Nikola Ciprich To: Xiaotian Feng Cc: linux-nfs@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "J. Bruce Fields" , Neil Brown , Trond Myklebust , "David S. Miller" , nikola.ciprich@linuxbox.cz, stable@kernel.org Subject: Re: [PATCH] sunrpc: fix peername failed on closed listener Message-ID: <20100104071216.GA14930@develbox.linuxbox.cz> References: <1262227956-21470-1-git-send-email-dfeng@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1262227956-21470-1-git-send-email-dfeng@redhat.com> User-Agent: Mutt/1.5.20 (2009-12-10) X-Milter-Copy-Status: I X-Antivirus: on proxybox by Kaspersky antivirus, engine 5.5.10, data 3114953 records(04-01-2010) X-Envelope-From: ciprich@linuxbox.cz X-Spam-Score: N/A (trusted relay) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2606 Lines: 72 (CCing stable@kernel.org) Greg, once this patch is ACKed, can You also queue it for 2.6.32.x please? thanks! nik On Thu, Dec 31, 2009 at 10:52:36AM +0800, Xiaotian Feng wrote: > There're some warnings of "nfsd: peername failed (err 107)!" > socket error -107 means Transport endpoint is not connected. > This warning message was outputed by svc_tcp_accept() [net/sunrpc/svcsock.c], > when kernel_getpeername returns -107. This means socket might be CLOSED. > > And svc_tcp_accept was called by svc_recv() [net/sunrpc/svc_xprt.c] > > if (test_bit(XPT_LISTENER, &xprt->xpt_flags)) { > > newxpt = xprt->xpt_ops->xpo_accept(xprt); > > > So this might happen when xprt->xpt_flags has both XPT_LISTENER and XPT_CLOSE. > > Let's take a look at commit b0401d72, this commit has moved the close > processing after do recvfrom method, but this commit also introduces this > warnings, if the xpt_flags has both XPT_LISTENER and XPT_CLOSED, we should > close it, not accpet then close. > > Signed-off-by: Xiaotian Feng > Cc: J. Bruce Fields > Cc: Neil Brown > Cc: Trond Myklebust > Cc: David S. Miller > --- > diff --git a/net/sunrpc/svc_xprt.c b/net/sunrpc/svc_xprt.c > index 1c924ee..187f0f4 100644 > --- a/net/sunrpc/svc_xprt.c > +++ b/net/sunrpc/svc_xprt.c > @@ -699,7 +699,8 @@ int svc_recv(struct svc_rqst *rqstp, long timeout) > spin_unlock_bh(&pool->sp_lock); > > len = 0; > - if (test_bit(XPT_LISTENER, &xprt->xpt_flags)) { > + if (test_bit(XPT_LISTENER, &xprt->xpt_flags) && > + !test_bit(XPT_CLOSE, &xprt->xpt_flags)) { > struct svc_xprt *newxpt; > newxpt = xprt->xpt_ops->xpo_accept(xprt); > if (newxpt) { > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- ------------------------------------- Ing. Nikola CIPRICH LinuxBox.cz, s.r.o. 28. rijna 168, 709 01 Ostrava tel.: +420 596 603 142 fax: +420 596 621 273 mobil: +420 777 093 799 www.linuxbox.cz mobil servis: +420 737 238 656 email servis: servis@linuxbox.cz ------------------------------------- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/