Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753094Ab0ADMjJ (ORCPT ); Mon, 4 Jan 2010 07:39:09 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752244Ab0ADMjG (ORCPT ); Mon, 4 Jan 2010 07:39:06 -0500 Received: from mail-ew0-f219.google.com ([209.85.219.219]:49302 "EHLO mail-ew0-f219.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752219Ab0ADMjE (ORCPT ); Mon, 4 Jan 2010 07:39:04 -0500 Date: Mon, 4 Jan 2010 12:38:58 +0000 From: Eric B Munson To: Hugh Dickins Cc: Linus Torvalds , Andrew Morton , Al Viro , David Howells , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm: move sys_mmap_pgoff from util.c Message-ID: <20100104123858.GA5045@us.ibm.com> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="NzB8fVQJ5HfG6fxh" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1432 Lines: 42 --NzB8fVQJ5HfG6fxh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, 30 Dec 2009, Hugh Dickins wrote: > Move sys_mmap_pgoff() from mm/util.c to mm/mmap.c and mm/nommu.c, > where we'd expect to find such code: especially now that it contains > the MAP_HUGETLB handling. Revert mm/util.c to how it was in 2.6.32. >=20 > This patch just ignores MAP_HUGETLB in the nommu case, as in 2.6.32, > whereas 2.6.33-rc2 reported -ENOSYS. Perhaps validate_mmap_request() > should reject it with -EINVAL? Add that later if necessary. >=20 > Signed-off-by: Hugh Dickins I think that -ENOSYS is the correcet response in the nommu case, but I that can be added in a later patch. Acked-by: Eric B Munson --NzB8fVQJ5HfG6fxh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEARECAAYFAktB4WIACgkQsnv9E83jkzrx6gCfVC8k0PisgYMmLXl7JWGdiZfc SnMAoIOoLNpwp9IzaEWBZErmlyO4gwL/ =t3b1 -----END PGP SIGNATURE----- --NzB8fVQJ5HfG6fxh-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/