Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754577Ab0AEC4W (ORCPT ); Mon, 4 Jan 2010 21:56:22 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754209Ab0AEC4V (ORCPT ); Mon, 4 Jan 2010 21:56:21 -0500 Received: from mx1.redhat.com ([209.132.183.28]:8686 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753481Ab0AEC4U (ORCPT ); Mon, 4 Jan 2010 21:56:20 -0500 Message-ID: <4B42AA40.3060406@redhat.com> Date: Tue, 05 Jan 2010 10:56:00 +0800 From: Xiaotian Feng User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-4.fc12 Lightning/1.0pre Thunderbird/3.0 MIME-Version: 1.0 To: Marc Dionne CC: Peter Zijlstra , linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar Subject: Re: BUG during shutdown - bisected to commit e2912009 References: <6041d2001001011627o5c494df4v37c0c466df3d444c@mail.gmail.com> <1262392920.32223.10.camel@laptop> <6041d2001001041043ka810288l64ae9d6d8105b284@mail.gmail.com> In-Reply-To: <6041d2001001041043ka810288l64ae9d6d8105b284@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2064 Lines: 52 On 01/05/2010 02:43 AM, Marc Dionne wrote: > On Fri, Jan 1, 2010 at 7:42 PM, Peter Zijlstra wrote: >> On Fri, 2010-01-01 at 19:27 -0500, Marc Dionne wrote: >>> I'm getting a BUG with current kernels from >>> kernel/time/clockevents.c:263 when halting the system - a restart >>> behaves normally. I don't have a good camera handy at the moment to >>> capture the call stack on screen, but the call sequence is: >>> >>> clockevents_notify >>> hrtimer_cpu_notify >>> notifier_call_chain >>> raw_notifier_call_chain >>> _cpu_down >>> disable_nonboot_cpus >>> kernel_power_off >>> sys_reboot >>> >>> I bisected it down to commit e2912009: sched: Ensure set_task_cpu() is >>> never called on blocked tasks. There were a few commits tested along >>> the way where I got a freeze (with the power still on) instead of a >>> BUG. Reverting that commit from the current kernel doesn't look >>> trivial, but the commit immediately preceding this one does halt fine. >> >> We somehow seem to trip up the below patch, which doesn't really make >> sense, as I can't find how task placement would affect the below error. >> >> It seems to purely test against the hot-unplugged cpu, not a cpu the >> task is running on. >> >> --- >> commit bb6eddf7676e1c1f3e637aa93c5224488d99036f >> Author: Thomas Gleixner >> Date: Thu Dec 10 15:35:10 2009 +0100 > > Probably predictable but worth testing, reverting that patch does > allow my system to shutdown cleanly. That BUG_ON was removed by reverting that patch, so you can shutdown cleanly. Could you please attach you kernel config file? I'm a little confused about how do you revert e2912009, manually? I can't see any connections between e2912009 and bb6eddf7, could you please show me your timer list (cat /proc/timer_list) > > Marc > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/