Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754232Ab0AEDUr (ORCPT ); Mon, 4 Jan 2010 22:20:47 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753472Ab0AEDUp (ORCPT ); Mon, 4 Jan 2010 22:20:45 -0500 Received: from mail-gx0-f211.google.com ([209.85.217.211]:64950 "EHLO mail-gx0-f211.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753577Ab0AEDUn (ORCPT ); Mon, 4 Jan 2010 22:20:43 -0500 From: Nitin Gupta To: Hugh Dickins , Pekka Enberg Cc: Al Viro , Christoph Hellwig , Jens Axboe , Andi Kleen , Andrew Morton , linux-kernel Subject: [PATCH 2/2] [mmotm] ramzswap: use slot free callback to eliminate stale data Date: Tue, 5 Jan 2010 08:48:34 +0530 Message-Id: <1262661514-4148-2-git-send-email-ngupta@vflare.org> X-Mailer: git-send-email 1.6.2.5 In-Reply-To: <1262661514-4148-1-git-send-email-ngupta@vflare.org> References: <1262661514-4148-1-git-send-email-ngupta@vflare.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3751 Lines: 92 ramzswap driver creates RAM backed block devices which are used as swap disks. Pages swapped to these disks are compressed and stored in memory itself. However, when a swap page becomes stale i.e. it is no longer referenced by any process (say, when owning process exits), the driver does not get any notification about this. So, it has to keep such pages in memory until kernel swaps to the same swap slot again thereby overwriting previous (stale) page. Often, a large number of such stale pages accumulate which defeats the whole purpose of in-memory compressed swapping and it begins to have a negative impact on system performance. To overcome this problem, we now register a callback function which is called as soon as a swap slot is freed which allows us to free corresponding memory, eliminating any stale data in (compressed) memory. Signed-off-by: Nitin Gupta --- drivers/staging/ramzswap/ramzswap_drv.c | 15 ++++++++++++++- drivers/staging/ramzswap/ramzswap_drv.h | 1 + drivers/staging/ramzswap/ramzswap_ioctl.h | 1 + 3 files changed, 16 insertions(+), 1 deletions(-) diff --git a/drivers/staging/ramzswap/ramzswap_drv.c b/drivers/staging/ramzswap/ramzswap_drv.c index b839f05..bada4ae 100644 --- a/drivers/staging/ramzswap/ramzswap_drv.c +++ b/drivers/staging/ramzswap/ramzswap_drv.c @@ -276,6 +276,7 @@ void ramzswap_ioctl_get_stats(struct ramzswap *rzs, s->failed_reads = rs->failed_reads; s->failed_writes = rs->failed_writes; s->invalid_io = rs->invalid_io; + s->notify_free = rs->notify_free; s->pages_zero = rs->pages_zero; s->good_compress_pct = good_compress_perc; @@ -1310,9 +1311,21 @@ out: return ret; } +void ramzswap_slot_free_notify(struct block_device *bdev, unsigned long index) +{ + struct ramzswap *rzs; + + rzs = bdev->bd_disk->private_data; + ramzswap_free_page(rzs, index); + stat_inc(rzs->stats.notify_free); + + return; +} + static struct block_device_operations ramzswap_devops = { .ioctl = ramzswap_ioctl, - .owner = THIS_MODULE, + .swap_slot_free_notify = ramzswap_slot_free_notify, + .owner = THIS_MODULE }; static void create_device(struct ramzswap *rzs, int device_id) diff --git a/drivers/staging/ramzswap/ramzswap_drv.h b/drivers/staging/ramzswap/ramzswap_drv.h index a6ea240..adc841a 100644 --- a/drivers/staging/ramzswap/ramzswap_drv.h +++ b/drivers/staging/ramzswap/ramzswap_drv.h @@ -124,6 +124,7 @@ struct ramzswap_stats { u64 failed_reads; /* can happen when memory is too low */ u64 failed_writes; /* should NEVER! happen */ u64 invalid_io; /* non-swap I/O requests */ + u64 notify_free; /* no. of swap slot free notifications */ u32 pages_zero; /* no. of zero filled pages */ u32 pages_stored; /* no. of pages currently stored */ u32 good_compress; /* % of pages with compression ratio<=50% */ diff --git a/drivers/staging/ramzswap/ramzswap_ioctl.h b/drivers/staging/ramzswap/ramzswap_ioctl.h index c713a09..ec50416 100644 --- a/drivers/staging/ramzswap/ramzswap_ioctl.h +++ b/drivers/staging/ramzswap/ramzswap_ioctl.h @@ -27,6 +27,7 @@ struct ramzswap_ioctl_stats { u64 failed_reads; /* can happen when memory is too low */ u64 failed_writes; /* should NEVER! happen */ u64 invalid_io; /* non-swap I/O requests */ + u64 notify_free; /* no. of swap slot free notifications */ u32 pages_zero; /* no. of zero filled pages */ u32 good_compress_pct; /* no. of pages with compression ratio<=50% */ u32 pages_expand_pct; /* no. of incompressible pages */ -- 1.6.2.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/