Date: Tue, 5 Jan 2010 10:52:08 +0100 (CET)
From: Jiri Kosina <jkosina@suse.cz>
To: "Rick L. Vinyard, Jr." <rvinyard@cs.nmsu.edu>
Cc: Pavel Machek <pavel@ucw.cz>, linux-kernel@vger.kernel.org,
       krzysztof.h1@wp.pl, Andrew Morton <akpm@linux-foundation.org>,
       linux-usb@vger.kernel.org, Oliver Neukum <oliver@neukum.org>,
       linux-input@vger.kernel.org
Subject: Re: [PATCH] Logitech G13 driver (fixed cc list --- ignore others)
In-Reply-To: <7f9100aac5f9b06ec78efff25c7a5a71.squirrel@intranet.cs.nmsu.edu>
Message-ID: <alpine.LNX.2.00.1001051048150.2277@pobox.suse.cz>
References: <200912142122.nBELMW7d001243@mustang.cs.nmsu.edu>    <20091216103423.GE1377@ucw.cz>    <alpine.LNX.2.00.0912161504360.3755@pobox.suse.cz> <7f9100aac5f9b06ec78efff25c7a5a71.squirrel@intranet.cs.nmsu.edu>
User-Agent: Alpine 2.00 (LNX 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1514
Lines: 39

On Mon, 4 Jan 2010, Rick L. Vinyard, Jr. wrote:

> >> > This patch is against the torvalds/linux-2.6.git tree.
> >>
> >> Should this use auxdisplay framework and be located there?
> >
> > Well, the device is still primarily HID device in its nature, so either
> > keeping the whole driver in drivers/hid, or separating it into two
> > drivers, one for the HID part and second for the framebuffer part should
> > be acceptable.
> 
> The framebuffer part uses the same interrupt endpoint for both HID and
> display. IIRC there were issues with two drivers using the same interrupt
> endpoint.

I have no objection to keeping this as a single driver in drivers/hid, 
provided that the framebuffer part gets reviewed by someone more familiar 
with the framebuffer code than I am.

> > I will proceed with reviewing the driver soon, sorry for slightly higher
> > latencies these days.
> 
> No problem... as you can see my latency responding is rather high.

Also please see the other thread about the build failures I am getting 
with this drivers (and it's not fixed solely by making the driver 
dependent on FB_DEFERRED_IO (namely it doesn't like to be built in as 
module, because of the symbol name clashes with hid-lg).

Thanks,

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/