Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754320Ab0AEKo4 (ORCPT ); Tue, 5 Jan 2010 05:44:56 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754022Ab0AEKoz (ORCPT ); Tue, 5 Jan 2010 05:44:55 -0500 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:57489 "EHLO www.etchedpixels.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753974Ab0AEKoz (ORCPT ); Tue, 5 Jan 2010 05:44:55 -0500 Date: Tue, 5 Jan 2010 10:47:46 +0000 From: Alan Cox To: Michael Breuer Cc: linux-kernel@vger.kernel.org Subject: Re: tty_io.c - disassociate_ctty attempted to write to tty = NULL question/problem? Message-ID: <20100105104746.095e5745@lxorguk.ukuu.org.uk> In-Reply-To: <4B42D297.5010702@majjas.com> References: <4B42733D.6050704@majjas.com> <20100105001205.7e8f131b@lxorguk.ukuu.org.uk> <4B42D297.5010702@majjas.com> X-Mailer: Claws Mail 3.7.3 (GTK+ 2.18.5; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 493 Lines: 11 > Ok - thanks - added a WARN_ON(!tty) right after the second call to > get_current_tty() in disassociate_ctty() Thsats a perfectly valid path. Its whatever is doing the write you need to catch. Having a NULL current tty is perfectly acceptable. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/