Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753568Ab0AENcO (ORCPT ); Tue, 5 Jan 2010 08:32:14 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751396Ab0AENcN (ORCPT ); Tue, 5 Jan 2010 08:32:13 -0500 Received: from casper.infradead.org ([85.118.1.10]:47432 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750967Ab0AENcM (ORCPT ); Tue, 5 Jan 2010 08:32:12 -0500 Date: Tue, 5 Jan 2010 05:34:43 -0800 From: Arjan van de Ven To: Heiko Carstens Cc: Ingo Molnar , David Miller , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: strict copy_from_user checks issues? Message-ID: <20100105053443.4a43fc18@infradead.org> In-Reply-To: <20100105094857.GB5480@osiris.boeblingen.de.ibm.com> References: <20100104154345.GA5671@osiris.boeblingen.de.ibm.com> <20100104174308.0790757c@infradead.org> <20100105094857.GB5480@osiris.boeblingen.de.ibm.com> Organization: Intel X-Mailer: Claws Mail 3.7.3 (GTK+ 2.16.6; i586-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1405 Lines: 38 On Tue, 5 Jan 2010 10:48:57 +0100 Heiko Carstens wrote: > > An allyesconfig triggers 52 warnings on s390 (see below). I just > checked a few but all of them looked like false positives. hmm I wonder why s390 gcc is so different.... if the s390 gcc isn't so good at proving things, maybe it's wrong to warn on s390? > In file included > from /home2/heicarst/cfu/arch/s390/include/asm/mmu_context.h:13, > from /home2/heicarst/cfu/arch/s390/include/asm/elf.h:133, from > include/linux/elf.h:7, from include/linux/module.h:14, from > drivers/net/tun.c:42: In function 'copy_from_user', > inlined from '__tun_chr_ioctl' at drivers/net/tun.c:1124: > /home2/heicarst/cfu/arch/s390/include/asm/uaccess.h:299: warning: > call to 'copy_from_user_overflow' declared with attribute warning: > copy_from_user() buffer size is not provably correct this one is ... interesting btw... I have trouble myself finding where the check is done... so I can understand gcc having trouble too. -- Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/