Return-Path: <linux-kernel-owner+w=401wt.eu-S1754782Ab0AEPEu@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754782Ab0AEPEu (ORCPT <rfc822;w@1wt.eu>);
	Tue, 5 Jan 2010 10:04:50 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754650Ab0AEPEr
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Tue, 5 Jan 2010 10:04:47 -0500
Received: from casper.infradead.org ([85.118.1.10]:35314 "EHLO
	casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754698Ab0AEPEq (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 5 Jan 2010 10:04:46 -0500
Date: Tue, 5 Jan 2010 07:06:58 -0800
From: Arjan van de Ven <arjan@linux.intel.com>
To: Rabin Vincent <rabin@rab.in>
Cc: Simon Horman <horms@verge.net.au>, mmarek@suse.cz, wangcong@zeuux.org,
       akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
       linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] scripts: add ARM support to decodecode
Message-ID: <20100105070658.766317d2@linux.intel.com>
In-Reply-To: <20100105145758.GA2690@debian>
References: <1262184839-24497-1-git-send-email-rabin@rab.in>
	<20091231051858.GA31256@verge.net.au>
	<20100105145758.GA2690@debian>
Organization: Intel
X-Mailer: Claws Mail 3.7.3 (GTK+ 2.16.6; i586-redhat-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1319
Lines: 36

On Tue, 5 Jan 2010 20:27:58 +0530
Rabin Vincent <rabin@rab.in> wrote:

> This patch adds support for decoding ARM oopses to scripts/decodecode.
> The following things are handled:
> 
>  - ARCH and CROSS_COMPILE environment variables are respected.
> 
>  - The Code: in x86 oopses is in bytes, while it is in either words (4
>    bytes) or halfwords for ARM.
> 
>  - Some versions of ARM objdump refuse to disassemble instructions
>    generated by literal constants (".word 0x...").  The workaround is
> to strip the object file first.
> 
>  - The faulting instruction is marked (liked so) in ARM, but <like so>
>    in x86.
> 
>  - ARM mnemonics may include characters such as [] which need to be
>    escaped before being passed to sed for the "<- trapping
> instruction" substitution.


I'm fine with this, but I wonder if ARM could switch to the <>
convention for the faulting instruction, just to keep things
consistent..

-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/