Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754488Ab0AEPWi (ORCPT ); Tue, 5 Jan 2010 10:22:38 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754339Ab0AEPWg (ORCPT ); Tue, 5 Jan 2010 10:22:36 -0500 Received: from nlpi157.sbcis.sbc.com ([207.115.36.171]:37981 "EHLO nlpi157.prodigy.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754377Ab0AEPWf (ORCPT ); Tue, 5 Jan 2010 10:22:35 -0500 Date: Tue, 5 Jan 2010 09:21:18 -0600 (CST) From: Christoph Lameter X-X-Sender: cl@router.home To: Tejun Heo cc: linux-kernel@vger.kernel.org, Mel Gorman , Pekka Enberg , Mathieu Desnoyers Subject: Re: [this_cpu_xx V9 4/7] Generic inc / dec percpu instructions In-Reply-To: <4B4293A3.10106@kernel.org> Message-ID: References: <20100104223439.228028923@quilx.com> <20100104223556.090044300@quilx.com> <4B4293A3.10106@kernel.org> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 608 Lines: 13 On Tue, 5 Jan 2010, Tejun Heo wrote: > According to gcc doc, __builtin_constant_p() returns 1 on constant and > 0 if not. It doesn't return the original expression. I'll commit the > following updated version after testing. Great. Thanks. That means that most of the percpu uses currently are incs and decs not adds. Machine worked fine with the buggy patch. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/