Return-Path: <linux-kernel-owner+w=401wt.eu-S1754821Ab0AEPe2@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754821Ab0AEPe2 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 5 Jan 2010 10:34:28 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750964Ab0AEPe1
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Tue, 5 Jan 2010 10:34:27 -0500
Received: from cantor2.suse.de ([195.135.220.15]:51328 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750738Ab0AEPe0 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 5 Jan 2010 10:34:26 -0500
Message-ID: <4B435BFF.10304@suse.cz>
Date: Tue, 05 Jan 2010 16:34:23 +0100
From: Michal Marek <mmarek@suse.cz>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091130 SUSE/3.0.0-1.2 Thunderbird/3.0
MIME-Version: 1.0
To: Arjan van de Ven <arjan@linux.intel.com>
Cc: Rabin Vincent <rabin@rab.in>, Simon Horman <horms@verge.net.au>,
       wangcong@zeuux.org, akpm@linux-foundation.org,
       linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] scripts: add ARM support to decodecode
References: <1262184839-24497-1-git-send-email-rabin@rab.in>	<20091231051858.GA31256@verge.net.au>	<20100105145758.GA2690@debian> <20100105070658.766317d2@linux.intel.com>
In-Reply-To: <20100105070658.766317d2@linux.intel.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1391
Lines: 42

On 5.1.2010 16:06, Arjan van de Ven wrote:
> On Tue, 5 Jan 2010 20:27:58 +0530
> Rabin Vincent <rabin@rab.in> wrote:
> 
>> This patch adds support for decoding ARM oopses to scripts/decodecode.
>> The following things are handled:
>>
>>  - ARCH and CROSS_COMPILE environment variables are respected.
>>
>>  - The Code: in x86 oopses is in bytes, while it is in either words (4
>>    bytes) or halfwords for ARM.
>>
>>  - Some versions of ARM objdump refuse to disassemble instructions
>>    generated by literal constants (".word 0x...").  The workaround is
>> to strip the object file first.
>>
>>  - The faulting instruction is marked (liked so) in ARM, but <like so>
>>    in x86.
>>
>>  - ARM mnemonics may include characters such as [] which need to be
>>    escaped before being passed to sed for the "<- trapping
>> instruction" substitution.
> 
> 
> I'm fine with this,

Was this an Acked-by? :)


> but I wonder if ARM could switch to the <>
> convention for the faulting instruction, just to keep things
> consistent..

I added the patch to the kbuild tree. () won't appear in the x86 Code:
line, so there should be no problem.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/