Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755327Ab0AETBK (ORCPT ); Tue, 5 Jan 2010 14:01:10 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755239Ab0AETAz (ORCPT ); Tue, 5 Jan 2010 14:00:55 -0500 Received: from mga12.intel.com ([143.182.124.36]:47821 "EHLO azsmga102.ch.intel.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755156Ab0AETAw (ORCPT ); Tue, 5 Jan 2010 14:00:52 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.47,316,1257148800"; d="scan'208";a="229487511" Date: Tue, 5 Jan 2010 20:02:31 +0100 From: Samuel Ortiz To: H Hartley Sweeten Cc: kernel list , Ben Dooks Subject: Re: [PATCH] sm501.c: use resource_size() Message-ID: <20100105190231.GG4274@sortiz.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1899 Lines: 53 On Fri, Dec 11, 2009 at 06:55:41PM -0500, H Hartley Sweeten wrote: > The requested memory region is smaller than the actual ioremap(). > Use resource_size() to get the correct size. Patch applied, thanks. > Signed-off-by: H Hartley Sweeten > Cc: Ben Dooks > Cc: Samuel Ortiz > > --- > > diff --git a/drivers/mfd/sm501.c b/drivers/mfd/sm501.c > index 0cc5eef..dc9ea95 100644 > --- a/drivers/mfd/sm501.c > +++ b/drivers/mfd/sm501.c > @@ -1430,7 +1430,7 @@ static int __devinit sm501_plat_probe(struct platform_device *dev) > } > > sm->regs_claim = request_mem_region(sm->io_res->start, > - 0x100, "sm501"); > + resource_size(sm->io_res), "sm501"); > > if (sm->regs_claim == NULL) { > dev_err(&dev->dev, "cannot claim registers\n"); > @@ -1440,8 +1440,7 @@ static int __devinit sm501_plat_probe(struct platform_device *dev) > > platform_set_drvdata(dev, sm); > > - sm->regs = ioremap(sm->io_res->start, > - (sm->io_res->end - sm->io_res->start) - 1); > + sm->regs = ioremap(sm->io_res->start, resource_size(sm->io_res)); > > if (sm->regs == NULL) { > dev_err(&dev->dev, "cannot remap registers\n"); > @@ -1645,7 +1644,7 @@ static int __devinit sm501_pci_probe(struct pci_dev *dev, > sm->mem_res = &dev->resource[0]; > > sm->regs_claim = request_mem_region(sm->io_res->start, > - 0x100, "sm501"); > + resource_size(sm->io_res), "sm501"); > if (sm->regs_claim == NULL) { > dev_err(&dev->dev, "cannot claim registers\n"); > err= -EBUSY; -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/