Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755170Ab0AEXgQ (ORCPT ); Tue, 5 Jan 2010 18:36:16 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750756Ab0AEXgP (ORCPT ); Tue, 5 Jan 2010 18:36:15 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:51170 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754043Ab0AEXgJ (ORCPT ); Tue, 5 Jan 2010 18:36:09 -0500 Date: Tue, 5 Jan 2010 15:35:27 -0800 (PST) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: Peter Zijlstra cc: KAMEZAWA Hiroyuki , "Paul E. McKenney" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "minchan.kim@gmail.com" , cl@linux-foundation.org, "hugh.dickins" , Nick Piggin , Ingo Molnar Subject: Re: [RFC][PATCH 6/8] mm: handle_speculative_fault() In-Reply-To: <1262684229.2400.37.camel@laptop> Message-ID: References: <20100104182429.833180340@chello.nl> <20100104182813.753545361@chello.nl> <20100105092559.1de8b613.kamezawa.hiroyu@jp.fujitsu.com> <1262684229.2400.37.camel@laptop> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 702 Lines: 18 On Tue, 5 Jan 2010, Peter Zijlstra wrote: > > While looking at that code, I found the placement of might_sleep() a tad > confusing, I'd expect that to be in fput() since that is the regular > entry point (all except AIO, which does crazy things). I think it's the crazy AIO thing that is one of the reasons for doing it in __fput. If it's just in fput() it covers the _normal_ cases better, but I doubt that those were the primary worry ;). Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/