Date: Tue, 5 Jan 2010 15:59:00 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: Debora Velarde <debora@linux.vnet.ibm.com>,
       Rajiv Andrade <srajiv@linux.vnet.ibm.com>,
       Marcel Selhorst <m.selhorst@sirrix.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tpm_infineon: Fix suspend/resume handler for pnp_driver
Message-Id: <20100105155900.7cf92358.akpm@linux-foundation.org>
In-Reply-To: <87d41xu18p.fsf@devron.myhome.or.jp>
References: <87d41xu18p.fsf@devron.myhome.or.jp>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1240
Lines: 35

On Wed, 30 Dec 2009 02:41:10 +0900
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> wrote:

> Hi,
> 
> With recent quick review, I found the bug of tpm_infineon. (I don't have
> this device, and compile test only)
> 

hm.  What bug?  Is there a bugzilla reference, or do you have a
description of that bug?  Perhaps the device is not functional after
suspend/resume?

This matters because people who are experiencing problems with this
device will want to know whether this patch is likely to fix them
(although that'll be pretty obvious in this case).

It also matters because people (ie: me) will want to know whether the
bug is sufficiently serious to warrant backporting the fix into earlier
-stable kernels.

Is the patch actually needed in earlier kernels?  It applies cleanly. 
When did this pnp_driver->suspend/resume requirement come about?

> PNP driver must use pnp_driver->suspend/resume anymore.

I assume this text should have read "PNP driver must use
pnp_driver->suspend/resume.".


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/