Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754594Ab0AFCe0 (ORCPT ); Tue, 5 Jan 2010 21:34:26 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754041Ab0AFCeV (ORCPT ); Tue, 5 Jan 2010 21:34:21 -0500 Received: from kirsty.vergenet.net ([202.4.237.240]:37220 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753087Ab0AFCeT (ORCPT ); Tue, 5 Jan 2010 21:34:19 -0500 Date: Wed, 6 Jan 2010 13:34:16 +1100 From: Simon Horman To: Joe Perches Cc: linux-kernel@vger.kernel.org, Wensong Zhang , Julian Anastasov , Patrick McHardy , "David S. Miller" , netdev@vger.kernel.org, lvs-devel@vger.kernel.org, netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org, coreteam@netfilter.org Subject: Re: [PATCH 6/8] net/netfilter/ipvs/ip_vs_ftp.c: Use standardized format in sprintf Message-ID: <20100106023416.GB18557@verge.net.au> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1430 Lines: 39 On Tue, Jan 05, 2010 at 05:20:18PM -0800, Joe Perches wrote: > Use the same format string as net/ipv4/netfilter/nf_nat_ftp.c > to encode an ipv4 address and port. > > Both uses should be a single common function. > > Signed-off-by: Joe Perches Acked-by: Simon Horman > --- > net/netfilter/ipvs/ip_vs_ftp.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/net/netfilter/ipvs/ip_vs_ftp.c b/net/netfilter/ipvs/ip_vs_ftp.c > index 33e2c79..73f38ea 100644 > --- a/net/netfilter/ipvs/ip_vs_ftp.c > +++ b/net/netfilter/ipvs/ip_vs_ftp.c > @@ -208,7 +208,7 @@ static int ip_vs_ftp_out(struct ip_vs_app *app, struct ip_vs_conn *cp, > */ > from.ip = n_cp->vaddr.ip; > port = n_cp->vport; > - sprintf(buf, "%d,%d,%d,%d,%d,%d", NIPQUAD(from.ip), > + sprintf(buf, "%u,%u,%u,%u,%u,%u", NIPQUAD(from.ip), > (ntohs(port)>>8)&255, ntohs(port)&255); > buf_len = strlen(buf); > > -- > 1.6.6.rc0.57.gad7a > > -- > To unsubscribe from this list: send the line "unsubscribe lvs-devel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/