Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755508Ab0AFHSI (ORCPT ); Wed, 6 Jan 2010 02:18:08 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754672Ab0AFHSB (ORCPT ); Wed, 6 Jan 2010 02:18:01 -0500 Received: from qw-out-2122.google.com ([74.125.92.24]:49453 "EHLO qw-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754570Ab0AFHSA (ORCPT ); Wed, 6 Jan 2010 02:18:00 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=l6s3Hq9JryBJXQU5zRFCAyzLujW05P50L4uHSjVHZp1Vd5uwoQZOeXvt9BXvyCma3p LsBoAsfkLoMm/e3T/0UyPlQXJ3qtT3OU2Dw+IADmFo2eo2bS4Uzc+ESasBKY9ZNUH89c jEStVYi2QNzz5ZlLUAhBfjG9hXCEJ+PIXMpPc= MIME-Version: 1.0 In-Reply-To: <20100106071026.GD1382@ucw.cz> References: <20100106071026.GD1382@ucw.cz> From: Eric Miao Date: Wed, 6 Jan 2010 15:17:39 +0800 Message-ID: Subject: Re: sharp c-3000 aka spitz: fix warn_on introduced in 2.6.32-rc1 To: Pavel Machek Cc: rpurdie@rpsys.net, lenz@cs.wisc.edu, kernel list , Dirk@opfer-online.de, arminlitzel@web.de, Cyril Hrubis , thommycheck@gmail.com, linux-arm-kernel , dbaryshkov@gmail.com, omegamoon@gmail.com, utx@penguin.cz, zaurus-devel@www.linuxtogo.org, "Rafael J. Wysocki" , Andrew Morton Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 701 Lines: 18 On Wed, Jan 6, 2010 at 3:10 PM, Pavel Machek wrote: > > Sharp-SL code uses strange, complex grouping of gpios for wakeups > toggling. Fortunately, it is unneeded in recent kernels (and actually > provokes WARN_ONs during resume). Remove it. > > Signed-off-by: Pavel Machek Pavel, The code to be removed below is used to support pxa27x_keypad to be able to resume from sleep. What's the exact reason to remove this on spitz? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/