Message-ID: <4B444DE8.1040609@linux.intel.com>
Date: Wed, 06 Jan 2010 16:46:32 +0800
From: Haicheng Li <haicheng.li@linux.intel.com>
User-Agent: Thunderbird 2.0.0.22 (X11/20090605)
MIME-Version: 1.0
To: Pekka Enberg <penberg@cs.helsinki.fi>
CC: Christoph Lameter <cl@linux-foundation.org>, linux-mm@kvack.org,
       Matt Mackall <mpm@selenic.com>, Andi Kleen <andi@firstfloor.org>,
       Eric Dumazet <eric.dumazet@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] slab: initialize unused alien cache entry as NULL
 at 	alloc_alien_cache().
References: <4B443AE3.2080800@linux.intel.com> <84144f021001060020v57535d5bwc65b482eca669bc5@mail.gmail.com> <4B444C39.3020901@linux.intel.com> <4B444CF4.50606@cs.helsinki.fi>
In-Reply-To: <4B444CF4.50606@cs.helsinki.fi>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1256
Lines: 34

understood. thanks!

Pekka Enberg wrote:
> Hi,
> 
> Haicheng Li wrote:
>> Pekka Enberg wrote:
>>  > I can find a trace of Andi acking the previous version of this patch
>>  > but I don't see an ACK from Christoph nor a revieved-by from Matt. Was
>>  > I not CC'd on those emails or what's going on here?
>>  >
>>
>> Christoph said he will ack this patch if remove the change of 
>> MAX_NUMNODES (see below),
>> so I add him directly as Acked-by in this revised patch. And also, I 
>> got review
>> comments from Matt for v1 and changed the patch accordingly.
>>
>> Is it a violation of the rule? if so, I'm sorry, actually not quite 
>> clear with the rule.
> 
> See Section 14 of Documentation/SubmittingPatches. You should never add 
> tags unless they came from the said person. The ACKs from Andi is fine, 
> the one from Christoph is borderline but OK and the one from Matt is 
> _not_ OK.
> 
> I can fix those up but I'll wait from an explicit ACK from Christoph first.
> 
>                         Pekka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/