Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932124Ab0AFJnT (ORCPT ); Wed, 6 Jan 2010 04:43:19 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932097Ab0AFJnS (ORCPT ); Wed, 6 Jan 2010 04:43:18 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36924 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932085Ab0AFJnR (ORCPT ); Wed, 6 Jan 2010 04:43:17 -0500 Message-ID: <4B445B0E.50208@redhat.com> Date: Wed, 06 Jan 2010 17:42:38 +0800 From: Xiaotian Feng User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-4.fc12 Lightning/1.0pre Thunderbird/3.0 MIME-Version: 1.0 To: Marc Dionne CC: Peter Zijlstra , linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar Subject: Re: BUG during shutdown - bisected to commit e2912009 References: <6041d2001001011627o5c494df4v37c0c466df3d444c@mail.gmail.com> <1262392920.32223.10.camel@laptop> <6041d2001001041043ka810288l64ae9d6d8105b284@mail.gmail.com> <4B42AA40.3060406@redhat.com> <6041d2001001041923u7bd512a6w4b5399af17424422@mail.gmail.com> <4B4311E8.1000001@redhat.com> <6041d2001001051458j46cdf7abqc4a0a249445ec348@mail.gmail.com> In-Reply-To: <6041d2001001051458j46cdf7abqc4a0a249445ec348@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1931 Lines: 42 On 01/06/2010 06:58 AM, Marc Dionne wrote: > On Tue, Jan 5, 2010 at 5:18 AM, Xiaotian Feng wrote: >> This is outputed by sound module, but it will not affect clockevents, could >> you please try following patch and let me know the output before BUG_ON >> happens? We can gather more information on the BUG_ON. Thank you. >> >> diff --git a/kernel/time/clockevents.c b/kernel/time/clockevents.c >> index 6f740d9..7c945e8 100644 >> --- a/kernel/time/clockevents.c >> +++ b/kernel/time/clockevents.c >> @@ -260,6 +260,9 @@ void clockevents_notify(unsigned long reason, void *arg) >> list_for_each_entry_safe(dev, tmp,&clockevent_devices, list) >> { >> if (cpumask_test_cpu(cpu, dev->cpumask)&& >> cpumask_weight(dev->cpumask) == 1) { >> + if (dev->mode != CLOCK_EVT_MODE_UNUSED) >> + printk("invalid dev %s mode %d on >> cpu %d\n", dev->name, >> + dev->mode, cpu); >> BUG_ON(dev->mode != CLOCK_EVT_MODE_UNUSED); >> list_del(&dev->list); > > I don't get anything on screen from the printk - is there a trick > needed to getting printk output at that stage of shutting down? I > tried inserting an mdelay() before the BUG, which delayed the bug > output but still didn't print the invalid dev message. Did you notice this BUG when you're doing suspend/resume? Does the BUG still appear if we changed BUG_ON line to BUG_ON(dev->mode != CLOCK_EVT_MODE_UNUSED && dev->mode != CLOCK_EVT_MODE_SHUTDOWN)? > > Thanks, > Marc > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/