Date: Wed, 6 Jan 2010 06:49:57 -0800
From: Stephen Hemminger <shemminger@vyatta.com>
To: Jarek Poplawski <jarkao2@gmail.com>
Cc: Michael Breuer <mbreuer@majjas.com>, David Miller <davem@davemloft.net>,
       akpm@linux-foundation.org, flyboy@gmail.com,
       linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH alt.2] af_packet: Don't use skb after dev_queue_xmit()
Message-ID: <20100106064957.3be271b8@nehalam>
In-Reply-To: <20100106091532.GA10201@ff.dom.local>
References: <20100105230746.GA6612@del.dom.local>
	<4B43F72C.9090004@majjas.com>
	<20100106072208.GA6711@ff.dom.local>
	<20100106091532.GA10201@ff.dom.local>
Organization: Vyatta
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 664
Lines: 20

On Wed, 6 Jan 2010 09:15:32 +0000
Jarek Poplawski <jarkao2@gmail.com> wrote:

> tpacket_snd() can change and kfree an skb after dev_queue_xmit(),
> which is illegal.
> 
> With debugging by: Stephen Hemminger <shemminger@linux-foundation.org>
> 
> Reported-by: Michael Breuer <mbreuer@majjas.com>
> Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>

Good catch.
Acked-by: Stephen Hemminger <shemminger@vyatta.com>

-- 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/