Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755937Ab0AFPsn (ORCPT ); Wed, 6 Jan 2010 10:48:43 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755919Ab0AFPsm (ORCPT ); Wed, 6 Jan 2010 10:48:42 -0500 Received: from bombadil.infradead.org ([18.85.46.34]:50203 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755184Ab0AFPsl (ORCPT ); Wed, 6 Jan 2010 10:48:41 -0500 Date: Wed, 6 Jan 2010 10:48:14 -0500 From: Christoph Hellwig To: Wu Fengguang Cc: Andrew Morton , David Miller , Stephen Rothwell , Al Viro , Christoph Hellwig , Eric Paris , LKML , linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] fs: O_* bit numbers uniqueness check Message-ID: <20100106154814.GA5172@infradead.org> References: <20100106065526.GB11368@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100106065526.GB11368@localhost> User-Agent: Mutt/1.5.19 (2009-01-05) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 582 Lines: 13 On Wed, Jan 06, 2010 at 02:55:26PM +0800, Wu Fengguang wrote: > The O_* bit numbers are defined in 20+ arch/*, and hence can silently > overlap. Add a boot time check to ensure the uniqueness as suggested > by David Miller. The right fix is to stop overlyaing the FMODE_ flags into the O_ namespace. Al has been working towards this. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/